From patchwork Wed Jun 14 16:51:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Przywara X-Patchwork-Id: 9786989 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F31596038E for ; Wed, 14 Jun 2017 16:55:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4A5A1FF15 for ; Wed, 14 Jun 2017 16:55:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D969A285E1; Wed, 14 Jun 2017 16:55:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6BF9E28604 for ; Wed, 14 Jun 2017 16:55:00 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLBWl-0006JF-4P; Wed, 14 Jun 2017 16:52:19 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLBWk-0006Ii-DP for xen-devel@lists.xenproject.org; Wed, 14 Jun 2017 16:52:18 +0000 Received: from [85.158.143.35] by server-11.bemta-6.messagelabs.com id 74/65-03587-2C961495; Wed, 14 Jun 2017 16:52:18 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRWlGSWpSXmKPExsVysyfVTfdgpmO kQWOTjsX3LZOZHBg9Dn+4whLAGMWamZeUX5HAmrHr3B+2gj1cFZNbDzM2MN7h6GLk4hAS2Mwo 8WHaGVYIZzmjxLptJxi7GDk52AR0JXbcfM0MYosIhEo8XfCdGaSIWeA6o8TpHfPZQBLCArYSe /YdZgGxWQRUJfafP8sOYvMKWElcvLoVLC4hICfRcP4+2CBOAWuJqdsnM3UxcgBts5K4uUJ/Ai P3AkaGVYwaxalFZalFukameklFmekZJbmJmTm6hgZmermpxcWJ6ak5iUnFesn5uZsYgR5mAII djKsWBB5ilORgUhLlnSroGCnEl5SfUpmRWJwRX1Sak1p8iFGGg0NJgvdwBlBOsCg1PbUiLTMH GGowaQkOHiUR3q2pQGne4oLE3OLMdIjUKUZFKXHesyB9AiCJjNI8uDZYeF9ilJUS5mUEOkSIp yC1KDezBFX+FaM4B6OSMG9ZOtAUnsy8Erjpr4AWMwEtDrrgALK4JBEhJdXAWNL0X11syUqR1r m1H80T7KPsg6Xv2pnesFmRoRTEuTSacYqF6x/XOL3jsbvupJ9ZdGm6wpbcCiepPwJP73t3bZu nv2xVcrZD3O+JTfp1G3JnyAc/zdYXXp53verhEe/NGWWm2htcHa9G1Hg3XayvmpfToVTwL+Tq qhtldxfl/tVWy5K8kMmpxFKckWioxVxUnAgAZatTvWoCAAA= X-Env-Sender: andre.przywara@arm.com X-Msg-Ref: server-14.tower-21.messagelabs.com!1497459137!67245828!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 57886 invoked from network); 14 Jun 2017 16:52:17 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-14.tower-21.messagelabs.com with SMTP; 14 Jun 2017 16:52:17 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0AB1F15A2; Wed, 14 Jun 2017 09:52:17 -0700 (PDT) Received: from e104803-lin.lan (unknown [10.1.207.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AED013F3E1; Wed, 14 Jun 2017 09:52:15 -0700 (PDT) From: Andre Przywara To: Julien Grall , Stefano Stabellini Date: Wed, 14 Jun 2017 17:51:51 +0100 Message-Id: <20170614165223.7543-3-andre.przywara@arm.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170614165223.7543-1-andre.przywara@arm.com> References: <20170614165223.7543-1-andre.przywara@arm.com> Cc: xen-devel@lists.xenproject.org, Vijaya Kumar K , Vijay Kilari , Shanker Donthineni , Manish Jaggi Subject: [Xen-devel] [PATCH v12 02/34] ARM: GICv3: enable ITS on the host X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Even though the ITS emulation is not yet in place, the host ITS already gets initialized and Xen tries to map the host collections. However for commands to be processed we need to *enable* the ITS, which will be done in a later patch not yet merged. So those MAPC commands are not processed and run into a timeout, leading to a panic on machines which advertise an ITS in their DT. This patch just enables the ITS (but not the LPIs on each redistributor), to get those MAPC commands executed. This fixes booting Xen on ARM64 machines with an ITS and the (EXPERT) ITS Kconfig option enabled. Signed-off-by: Andre Przywara Acked-by: Julien Grall --- xen/arch/arm/gic-v3-its.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 07280b3..aebc257 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -505,6 +505,10 @@ static int gicv3_its_init_single_its(struct host_its *hw_its) return -ENOMEM; writeq_relaxed(0, hw_its->its_base + GITS_CWRITER); + /* Now enable interrupt translation and command processing on that ITS. */ + reg = readl_relaxed(hw_its->its_base + GITS_CTLR); + writel_relaxed(reg | GITS_CTLR_ENABLE, hw_its->its_base + GITS_CTLR); + return 0; }