From patchwork Mon Jul 17 17:47:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9845869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E59C60392 for ; Mon, 17 Jul 2017 17:49:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 601822656B for ; Mon, 17 Jul 2017 17:49:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54ABF2821F; Mon, 17 Jul 2017 17:49:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 005442656B for ; Mon, 17 Jul 2017 17:49:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXA6x-0005Rw-56; Mon, 17 Jul 2017 17:47:11 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXA6v-0005RP-Bg for xen-devel@lists.xenproject.org; Mon, 17 Jul 2017 17:47:09 +0000 Received: from [85.158.143.35] by server-10.bemta-6.messagelabs.com id C2/63-03582-C18FC695; Mon, 17 Jul 2017 17:47:08 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRWlGSWpSXmKPExsVyuP0Ov670j5x Ig+33bSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1oypK3axF7zmqXixbQVLA+Nzri5GTg4JASOJ txP/MYHYQgILGSXmLGIHsdkEVCU2XD/FCmKLCARJbOhoBathFqiQaPl/iaWLkYNDGCi+45YbS JgFqPz9lXvMIDavgLHE+uOf2CHGy0t0HJjMAmJzCphIfGrcBrXKWOLu5DeMExi5FzAyrGLUKE 4tKkst0jUy0ksqykzPKMlNzMzRNTQw08tNLS5OTE/NSUwq1kvOz93ECPQtAxDsYFwzP/AQoyQ Hk5Io70W27EghvqT8lMqMxOKM+KLSnNTiQ4wyHBxKEryZ33IihQSLUtNTK9Iyc4BBBpOW4OBR EuHtAEnzFhck5hZnpkOkTjEac2xYvf4LE8erCf+/MQmx5OXnpUqJ86aAlAqAlGaU5sENggX/J UZZKWFeRqDThHgKUotyM0tQ5V8xinMwKgnzeoFM4cnMK4Hb9wroFCagU4R9wU4pSURISTUwMn e97tvs3Z/7b9W9FMNAvvoJ7tXx+7NbEn7/cT/+/tjpHYczmf/uU29OZ9Q0c2mLWbBpmtri1PA X35a+e1Zrk1a3fuXypOjlfj/LS2Xuulq+qjhi9XCdqtKTlqJ7dRJzHh2Y6P5j79+6ByUz+e77 HY4SO/X53bGsknt3Tbj2VVQuT5VkdjjEr8RSnJFoqMVcVJwIAHyYeWB5AgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-12.tower-21.messagelabs.com!1500313627!73647008!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.25; banners=-,-,- X-VirusChecked: Checked Received: (qmail 65373 invoked from network); 17 Jul 2017 17:47:07 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-12.tower-21.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 17 Jul 2017 17:47:07 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8BBD5AB9B; Mon, 17 Jul 2017 17:47:07 +0000 (UTC) From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Date: Mon, 17 Jul 2017 19:47:03 +0200 Message-Id: <20170717174703.4603-3-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170717174703.4603-1-jgross@suse.com> References: <20170717174703.4603-1-jgross@suse.com> Cc: Juergen Gross , boris.ostrovsky@oracle.com, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com Subject: [Xen-devel] [PATCH 2/2] xen: dont fiddle with event channel masking in suspend/resume X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Instead of fiddling with masking the event channels during suspend and resume handling let do the irq subsystem do its job. It will do the mask and unmask operations as needed. Signed-off-by: Juergen Gross Acked-by: Thomas Gleixner Reviewed-by: Boris Ostrovsky --- drivers/xen/events/events_base.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index b241bfa529ce..bae1f5d36c26 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -343,14 +343,6 @@ static void bind_evtchn_to_cpu(unsigned int chn, unsigned int cpu) info->cpu = cpu; } -static void xen_evtchn_mask_all(void) -{ - unsigned int evtchn; - - for (evtchn = 0; evtchn < xen_evtchn_nr_channels(); evtchn++) - mask_evtchn(evtchn); -} - /** * notify_remote_via_irq - send event to remote end of event channel via irq * @irq: irq of event channel to send event to @@ -1573,7 +1565,6 @@ void xen_irq_resume(void) struct irq_info *info; /* New event-channel space is not 'live' yet. */ - xen_evtchn_mask_all(); xen_evtchn_resume(); /* No IRQ <-> event-channel mappings. */ @@ -1681,6 +1672,7 @@ module_param(fifo_events, bool, 0); void __init xen_init_IRQ(void) { int ret = -EINVAL; + unsigned int evtchn; if (fifo_events) ret = xen_evtchn_fifo_init(); @@ -1692,7 +1684,8 @@ void __init xen_init_IRQ(void) BUG_ON(!evtchn_to_irq); /* No event channels are 'live' right now. */ - xen_evtchn_mask_all(); + for (evtchn = 0; evtchn < xen_evtchn_nr_channels(); evtchn++) + mask_evtchn(evtchn); pirq_needs_eoi = pirq_needs_eoi_flag;