From patchwork Wed Aug 9 07:06:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9889707 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01178602D7 for ; Wed, 9 Aug 2017 07:10:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E904D26BE9 for ; Wed, 9 Aug 2017 07:10:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DDED0274D1; Wed, 9 Aug 2017 07:10:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 68D9326BE9 for ; Wed, 9 Aug 2017 07:10:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfL6V-0001xf-PK; Wed, 09 Aug 2017 07:08:31 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfL6U-0001tt-Mj for xen-devel@lists.xen.org; Wed, 09 Aug 2017 07:08:30 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 25/74-02177-DE4BA895; Wed, 09 Aug 2017 07:08:29 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRWlGSWpSXmKPExsVyuP0Ov+7bLV2 RBrtnylks+biYxYHR4+ju30wBjFGsmXlJ+RUJrBnbZs5nLWjjqpgwewNrA+Mn9i5GTg4JASOJ txP/MXUxcnEICSxklNi0+TwjSIJNQFViw/VTrCC2iIC0xLXPl8HizALuEhvfNbGA2MIC+RIvZ u0EquHgYAGq3/czGyTMK2Aq8XrrREaI+fISHQcmg5VzAsWnvNzOBGILCZhI3Do7jW0CI/cCRo ZVjBrFqUVlqUW6hsZ6SUWZ6RkluYmZObqGBsZ6uanFxYnpqTmJScV6yfm5mxiB3mUAgh2M27Z 7HmKU5GBSEuXdpN0ZKcSXlJ9SmZFYnBFfVJqTWnyIUYaDQ0mC99mmrkghwaLU9NSKtMwcYJjB pCU4eJREeDtA0rzFBYm5xZnpEKlTjLocryb8/8YkxJKXn5cqJc7bvBmoSACkKKM0D24ELOQvM cpKCfMyAh0lxFOQWpSbWYIq/4pRnINRSZj3DMgUnsy8ErhNr4COYAI6IsK3E+SIkkSElFQDo+ OhixMuWvma71AuaHWfJzQ3NYFfKeHNOj+b1DPNXxZWBDXc8/4Ruf/i+/5OJrF1sXv+BIbc6Fl wwUDzopHDHk5HhpMtdjXGZnus++fPC/vWaPzNI7WvaltRrpDAxu9xB95fUrp0L+LzQ4ntVRl5 3Omckaz/Vt8Nd6hOd2Vb4H/4ZvP0xVXySizFGYmGWsxFxYkAJzU5KXQCAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1502262509!108505246!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14055 invoked from network); 9 Aug 2017 07:08:29 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-10.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 9 Aug 2017 07:08:29 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2EC54AF14; Wed, 9 Aug 2017 07:07:29 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xen.org Date: Wed, 9 Aug 2017 09:06:50 +0200 Message-Id: <20170809070706.13481-37-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170809070706.13481-1-jgross@suse.com> References: <20170809070706.13481-1-jgross@suse.com> Cc: Juergen Gross , Kevin Tian Subject: [Xen-devel] [PATCH 36/52] xen/drivers/passthrough/vtd/quirks.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/drivers/passthrough/vtd/quirks.c to indicate whether the parameter value was parsed successfully. Cc: Kevin Tian Signed-off-by: Juergen Gross --- xen/drivers/passthrough/vtd/quirks.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c index 5bbbd96d51..4e61ac9ddb 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -247,9 +247,10 @@ void vtd_ops_postamble_quirk(struct iommu* iommu) } } -static void __init parse_snb_timeout(const char *s) +static int __init parse_snb_timeout(const char *s) { int t; + const char *q = NULL; t = parse_bool(s); if ( t < 0 ) @@ -259,13 +260,13 @@ static void __init parse_snb_timeout(const char *s) else if ( strcmp(s, "cap") == 0 ) t = SNB_IGD_TIMEOUT; else - t = strtoul(s, NULL, 0); + t = strtoul(s, &q, 0); } else t = t ? SNB_IGD_TIMEOUT_LEGACY : 0; snb_igd_timeout = MILLISECS(t); - return; + return (q && *q) ? -EINVAL : 0; } custom_param("snb_igd_quirk", parse_snb_timeout);