From patchwork Wed Aug 9 07:06:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9889675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0DC9B602D7 for ; Wed, 9 Aug 2017 07:10:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01CB026BE9 for ; Wed, 9 Aug 2017 07:10:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EACCF274D1; Wed, 9 Aug 2017 07:09:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A2DAD26BE9 for ; Wed, 9 Aug 2017 07:09:59 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfL5Q-0007w9-4B; Wed, 09 Aug 2017 07:07:24 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfL5O-0007uG-KI for xen-devel@lists.xen.org; Wed, 09 Aug 2017 07:07:22 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id E1/19-01732-9A4BA895; Wed, 09 Aug 2017 07:07:21 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRWlGSWpSXmKPExsVyuP0Ov+7KLV2 RBg2/JC2WfFzM4sDocXT3b6YAxijWzLyk/IoE1ozzJ/4zF7zhqvjTv56pgbGds4uRk0NCwEji 7cR/TF2MXBxCAgsZJc5+ecEGkmATUJXYcP0UK4gtIiAtce3zZUYQm1mgUOJkdx9YXFggSeLF3 s9MIDYLUP3b+d+Zuxg5OHgFTCQm/uOBmC8v0XFgMguIzSlgKjHl5XawciGgkltnp7FNYORewM iwilGjOLWoLLVI19hAL6koMz2jJDcxM0fX0MBYLze1uDgxPTUnMalYLzk/dxMj0Lv1DAyMOxg 7T/gdYpTkYFIS5d2k3RkpxJeUn1KZkVicEV9UmpNafIhRhoNDSYLXc3NXpJBgUWp6akVaZg4w zGDSEhw8SiK8HZuA0rzFBYm5xZnpEKlTjLocryb8/8YkxJKXn5cqJc7bDDJDAKQoozQPbgQs5 C8xykoJ8zIyMDAI8RSkFuVmlqDKv2IU52BUEuYNA5nCk5lXArfpFdARTEBHRPh2ghxRkoiQkm pg5M+cZH7+/w1LrXt/lrDOrHi9R1sjarKJNPdNZo6vgb4hRy06rvt+n/nM8p/jHwHVtsqPJxy kL8uX5m2KUsicfjcmcNH8qaunfX198ZmtrMEnlnivX/p8Mx6cV/aY/KVTjfnGMmGdi1sqX8k3 3b15KixwldqG2t1z9FReef6zeNoUFLeRfUXlRyWW4oxEQy3mouJEACjd9i90AgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1502262441!51125299!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 37705 invoked from network); 9 Aug 2017 07:07:21 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-4.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 9 Aug 2017 07:07:21 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 27E13AF11; Wed, 9 Aug 2017 07:07:21 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xen.org Date: Wed, 9 Aug 2017 09:06:20 +0200 Message-Id: <20170809070706.13481-7-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170809070706.13481-1-jgross@suse.com> References: <20170809070706.13481-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH 06/52] xen/arch/x86/cpu/vpmu.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/cpu/vpmu.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross --- xen/arch/x86/cpu/vpmu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index 90954ca884..8f56e2bb6c 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -53,7 +53,7 @@ CHECK_pmu_params; static unsigned int __read_mostly opt_vpmu_enabled; unsigned int __read_mostly vpmu_mode = XENPMU_MODE_OFF; unsigned int __read_mostly vpmu_features = 0; -static void parse_vpmu_params(char *s); +static int parse_vpmu_params(char *s); custom_param("vpmu", parse_vpmu_params); static DEFINE_SPINLOCK(vpmu_lock); @@ -76,7 +76,7 @@ static int parse_vpmu_param(char *s, unsigned int len) return 0; } -static void __init parse_vpmu_params(char *s) +static int __init parse_vpmu_params(char *s) { char *sep, *p = s; @@ -104,10 +104,11 @@ static void __init parse_vpmu_params(char *s) opt_vpmu_enabled = 1; break; } - return; + return 0; error: printk("VPMU: unknown flags: %s - vpmu disabled!\n", s); + return -EINVAL; } void vpmu_lvtpc_update(uint32_t val)