From patchwork Thu Aug 10 11:24:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9893307 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0003B60236 for ; Thu, 10 Aug 2017 11:26:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E8FB928A1A for ; Thu, 10 Aug 2017 11:26:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DDB3328AE9; Thu, 10 Aug 2017 11:26:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 551E428A1A for ; Thu, 10 Aug 2017 11:26:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dflZt-00005b-Eo; Thu, 10 Aug 2017 11:24:37 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dflZs-00005F-L0 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2017 11:24:36 +0000 Received: from [85.158.139.211] by server-16.bemta-5.messagelabs.com id 7C/C2-01712-3724C895; Thu, 10 Aug 2017 11:24:35 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRWlGSWpSXmKPExsVyuP0Ov26RU0+ kQf8/MYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNePOnJuMBS85Kn6tj2lgnMLexcjJISFgJPF2 4j+mLkYuDiGBhYwS709dZQNJsAmoSmy4fooVxBYRUJK4t2oyUBEHB7NAocSzLzwgYWEBe4m2c 51gc1iAyt+/+MUIYvMKGEs8eHAbar68RMeBySwTGDkXMDKsYtQoTi0qSy3SNTLWSyrKTM8oyU 3MzNE1NDDVy00tLk5MT81JTCrWS87P3cQI9FU9AwPjDsYd7X6HGCU5mJREeYs/dUcK8SXlp1R mJBZnxBeV5qQWH2KU4eBQkuCd79gTKSRYlJqeWpGWmQMMGpi0BAePkgjvKQegNG9xQWJucWY6 ROoUoy7Hqwn/vzEJseTl56VKifOqgswQACnKKM2DGwEL4EuMslLCvIwMDAxCPAWpRbmZJajyr xjFORiVhHmngkzhycwrgdv0CugIJqAjInw7QY4oSURISTUw8rZxiO8SePLp17Pr1Wc+7Hxlxr Du6s0F+alVCk+Xdjws73BbfpsnbW0HI+eF6U/ll/fw1hV/KDkUqPF6etu3Sy+85K19/UTDC0p cdxyquOq+k2HjabODQZebGrovmkZ/aRKT/2327K9G7KZi+3zJ1GlMUif3tP5LuDNJSTlBTtJn zc7aA4zBSizFGYmGWsxFxYkAbW4/9FsCAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1502364274!90802362!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8229 invoked from network); 10 Aug 2017 11:24:34 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-16.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 10 Aug 2017 11:24:34 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A60EDAE51; Thu, 10 Aug 2017 11:24:33 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Thu, 10 Aug 2017 13:24:27 +0200 Message-Id: <20170810112428.5769-1-jgross@suse.com> X-Mailer: git-send-email 2.12.3 Cc: Juergen Gross , andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, wei.liu2@citrix.com Subject: [Xen-devel] [PATCH] libxc: correct error message in xc_sr_common.c X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP When the record length for sending the p2m frames in a migration stream is too large, the issued error message is not very helpful: xc: Record (0x00000003, x86 PV P2M frames) length 0x8 exceeds max (0x800000): Internal error When printing the error use the size which was tested instead that of the record header length. Signed-off-by: Juergen Gross Reviewed-by: Andrew Cooper Acked-by: Wei Liu --- tools/libxc/xc_sr_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxc/xc_sr_common.c b/tools/libxc/xc_sr_common.c index 48fa676f4e..79b9c3e940 100644 --- a/tools/libxc/xc_sr_common.c +++ b/tools/libxc/xc_sr_common.c @@ -71,8 +71,8 @@ int write_split_record(struct xc_sr_context *ctx, struct xc_sr_record *rec, if ( record_length > REC_LENGTH_MAX ) { - ERROR("Record (0x%08x, %s) length %#x exceeds max (%#x)", rec->type, - rec_type_to_str(rec->type), rec->length, REC_LENGTH_MAX); + ERROR("Record (0x%08x, %s) length %#zx exceeds max (%#x)", rec->type, + rec_type_to_str(rec->type), record_length, REC_LENGTH_MAX); return -1; }