From patchwork Mon Aug 14 07:08:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9898191 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2DA496038C for ; Mon, 14 Aug 2017 07:11:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20D7026538 for ; Mon, 14 Aug 2017 07:11:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 15BA526E4A; Mon, 14 Aug 2017 07:11:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9A0C526E1A for ; Mon, 14 Aug 2017 07:11:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Uq-0003lC-Mw; Mon, 14 Aug 2017 07:09:08 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Up-0003gk-P8 for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 07:09:07 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id A2/D0-01862-39C41995; Mon, 14 Aug 2017 07:09:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ov+4kn4m RBrMOWFh83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBnzb/9nKvjHWTHn6zzGBsZNHF2MnBwSAkYS byf+Y+pi5OIQEljIKHH6yVRWkASbgKrEhuunwGwRASWJe6smM4HYzALuEhvfNbGA2MICBRJ7t 7awgdgsQPXHlmxjBrF5BUwlVp1czgaxQF6i48BksHpOoPilfUvBbCEBE4m+rV0sExi5FzAyrG LUKE4tKkst0jWy0EsqykzPKMlNzMzRNTQw1stNLS5OTE/NSUwq1kvOz93ECPRvPQMD4w7G9hN +hxglOZiURHkTfHojhfiS8lMqMxKLM+KLSnNSiw8xynBwKEnwzvCeGCkkWJSanlqRlpkDDDSY tAQHj5II7wqQNG9xQWJucWY6ROoUoy7Hqwn/vzEJseTl56VKifM+BSkSACnKKM2DGwEL+kuMs lLCvIwMDAxCPAWpRbmZJajyrxjFORiVhHm3gUzhycwrgdv0CugIJqAj+kDu5y0uSURISTUw2j z49EFtV7DhPtlLi76p/cxaXqr10/rtZre4DJVgeSsmRn/WyV8ulb2suVp6YafXrbok07TpKev +Xf2ysVPbTpHpf+ZGxj+C2cY+9jEKLR+NnVX6Hh+dM+tNQm9pxJJn2y+br8uVnhLofGATs8JF KYFNDX8s5/9Y1BH97EulVJCky+tbmsz3lViKMxINtZiLihMBV++kmXUCAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-9.tower-31.messagelabs.com!1502694546!54381907!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 18332 invoked from network); 14 Aug 2017 07:09:06 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-9.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 14 Aug 2017 07:09:06 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9B2D1AD57; Mon, 14 Aug 2017 07:09:06 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 14 Aug 2017 09:08:32 +0200 Message-Id: <20170814070849.20986-36-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170814070849.20986-1-jgross@suse.com> References: <20170814070849.20986-1-jgross@suse.com> Cc: Juergen Gross , Kevin Tian Subject: [Xen-devel] [PATCH v2 35/52] xen/drivers/passthrough/vtd/dmar.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/drivers/passthrough/vtd/dmar.c to indicate whether the parameter value was parsed successfully. Cc: Kevin Tian Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/drivers/passthrough/vtd/dmar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 82040ddc05..dd122da730 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -1090,7 +1090,7 @@ int intel_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt) * If a segment is specified for other than the first device, and it does not * match the one specified for the first one, an error will be reported. */ -static void __init parse_rmrr_param(const char *str) +static int __init parse_rmrr_param(const char *str) { const char *s = str, *cur, *stmp; unsigned int seg, bus, dev, func, dev_count; @@ -1143,5 +1143,7 @@ static void __init parse_rmrr_param(const char *str) nr_rmrr++; } while ( *s++ == ';' && nr_rmrr < MAX_USER_RMRR ); + + return *s ? -EINVAL : 0; } custom_param("rmrr", parse_rmrr_param);