From patchwork Wed Aug 16 12:51:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9903621 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E3B006038C for ; Wed, 16 Aug 2017 12:54:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5731289CD for ; Wed, 16 Aug 2017 12:54:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C8D57289E1; Wed, 16 Aug 2017 12:54:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5A1FC289CD for ; Wed, 16 Aug 2017 12:54:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoD-0008JU-C9; Wed, 16 Aug 2017 12:52:29 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoB-0008Hh-UC for xen-devel@lists.xenproject.org; Wed, 16 Aug 2017 12:52:28 +0000 Received: from [85.158.139.211] by server-13.bemta-5.messagelabs.com id E3/8E-01732-B0044995; Wed, 16 Aug 2017 12:52:27 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ovy6nw5R Ig5Pf9Cy+b5nM5MDocfjDFZYAxijWzLyk/IoE1ow529awFMzirFgy6yVbA+Mp9i5GTg4JASOJ txP/MXUxcnEICSxklLj+dhYLSIJNQFViw/VTrCC2iICSxL1Vk5lAbGaBQomT3X1gcWGBFImG6 aeZQWwWoPoJ3/6CxXkFTCQOr3vDBrFAXqLjwGSwmZxA8ckbjoHZQgLGEtt7GtknMHIvYGRYxa hRnFpUllqka2ikl1SUmZ5RkpuYmaNraGCql5taXJyYnpqTmFSsl5yfu4kR6F8GINjB2DfL+RC jJAeTkihvkNaUSCG+pPyUyozE4oz4otKc1OJDjDIcHEoSvIvsgHKCRanpqRVpmTnAQINJS3Dw KInwptkCpXmLCxJzizPTIVKnGHU5Xk34/41JiCUvPy9VSpz3FsgMAZCijNI8uBGwoL/EKCslz MsIdJQQT0FqUW5mCar8K0ZxDkYlYd6rIFN4MvNK4Da9AjqCCeiIK+2TQI4oSURISTUw9h+tKL Gdp7J66+fXZWtsrO8fNRG5q54c91bi74w9DOH3re5JMHYIGIvaLmHeXNl3TrUyYfWpvzl71zA 5WjMclZx2c13x9qev5V4GPrlrKXI8wWyHn+quRU5vLueuyubIPZa2fq3wCf7XjT3KC22akqTs H05knfhi/s9PgvZahq99jDoYih7dVWIpzkg01GIuKk4EADIesJF1AgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-11.tower-206.messagelabs.com!1502887945!86395934!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4697 invoked from network); 16 Aug 2017 12:52:25 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-11.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 16 Aug 2017 12:52:25 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 727D7AE9A; Wed, 16 Aug 2017 12:52:25 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 16 Aug 2017 14:51:38 +0200 Message-Id: <20170816125219.5255-12-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170816125219.5255-1-jgross@suse.com> References: <20170816125219.5255-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v3 11/52] xen/arch/x86/io_apic.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/io_apic.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/io_apic.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 2838f6bd99..f767c4560c 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1581,7 +1581,7 @@ static unsigned int startup_level_ioapic_irq(struct irq_desc *desc) return 0; /* don't check for pending */ } -static void __init setup_ioapic_ack(char *s) +static int __init setup_ioapic_ack(const char *s) { if ( !strcmp(s, "old") ) { @@ -1594,7 +1594,12 @@ static void __init setup_ioapic_ack(char *s) ioapic_ack_forced = true; } else + { printk("Unknown ioapic_ack value specified: '%s'\n", s); + return -EINVAL; + } + + return 0; } custom_param("ioapic_ack", setup_ioapic_ack);