From patchwork Wed Aug 16 12:51:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9903665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8CE116038C for ; Wed, 16 Aug 2017 12:54:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C7DF289CD for ; Wed, 16 Aug 2017 12:54:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F3AD289E0; Wed, 16 Aug 2017 12:54:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 164A6289CD for ; Wed, 16 Aug 2017 12:54:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoC-0008J0-UB; Wed, 16 Aug 2017 12:52:28 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoB-0008HA-Cb for xen-devel@lists.xenproject.org; Wed, 16 Aug 2017 12:52:27 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id 7F/C9-01993-A0044995; Wed, 16 Aug 2017 12:52:26 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRWlGSWpSXmKPExsVyuP0Ovy6Xw5R Ig/dz2Cy+b5nM5MDocfjDFZYAxijWzLyk/IoE1oxTe94zF3zkr/jU95S1gXETTxcjJ4eEgJHE 24n/mEBsIYGFjBINT5xAbDYBVYkN10+xgtgiAkoS91ZNBqthFiiUONndBxYXFkiQWD35BTOIz QJU/7/zBVicV8BE4teDd0wQ8+UlOg5MZgGxOYHikzccY4HYZSyxvaeRfQIj9wJGhlWM6sWpRW WpRbqGeklFmekZJbmJmTm6hgamermpxcWJ6ak5iUnFesn5uZsYgb6tZ2Bg3MHY1Ot8iFGSg0l JlDdIa0qkEF9SfkplRmJxRnxRaU5q8SFGGQ4OJQneRXZAOcGi1PTUirTMHGCQwaQlOHiURHjT bIHSvMUFibnFmekQqVOMuhyvJvz/xiTEkpeflyolznsLZIYASFFGaR7cCFjAX2KUlRLmZWRgY BDiKUgtys0sQZV/xSjOwagkzCthDzSFJzOvBG7TK6AjmICOuNI+CeSIkkSElFQDY8zyJ1eajR 6vzlT/VmPTf+aYfS+b7cNZmzvfHNj6NjL9ioPvhqjYP9nuPXHZx6d739rD+DdUtHHaGa/lZ+4 qhclKr4zeU387jnumZKrPP3mPtQKRp2+wPkw02h3N+Nm0XnVChcPCB6d+6S6NndLpPsH3ZFPw k7ArU2f6ylX9m7boyvp/q09MSFJiKc5INNRiLipOBADML9ELcwIAAA== X-Env-Sender: jgross@suse.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1502887945!103938835!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5806 invoked from network); 16 Aug 2017 12:52:26 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-3.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 16 Aug 2017 12:52:26 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B0CFCAE9C; Wed, 16 Aug 2017 12:52:25 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 16 Aug 2017 14:51:39 +0200 Message-Id: <20170816125219.5255-13-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170816125219.5255-1-jgross@suse.com> References: <20170816125219.5255-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v3 12/52] xen/arch/x86/irq.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/irq.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/irq.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 57e6c18970..77ca181985 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -26,7 +26,7 @@ #include #include -static void parse_irq_vector_map_param(char *s); +static int parse_irq_vector_map_param(const char *s); /* opt_noirqbalance: If true, software IRQ balancing/affinity is disabled. */ bool __read_mostly opt_noirqbalance; @@ -60,24 +60,29 @@ static struct timer irq_ratelimit_timer; static unsigned int __read_mostly irq_ratelimit_threshold = 10000; integer_param("irq_ratelimit", irq_ratelimit_threshold); -static void __init parse_irq_vector_map_param(char *s) +static int __init parse_irq_vector_map_param(const char *s) { - char *ss; + const char *ss; + int rc = 0; do { ss = strchr(s, ','); - if ( ss ) - *ss = '\0'; + if ( !ss ) + ss = strchr(s, '\0'); - if ( !strcmp(s, "none")) + if ( !strncmp(s, "none", ss - s)) opt_irq_vector_map=OPT_IRQ_VECTOR_MAP_NONE; - else if ( !strcmp(s, "global")) + else if ( !strncmp(s, "global", ss - s)) opt_irq_vector_map=OPT_IRQ_VECTOR_MAP_GLOBAL; - else if ( !strcmp(s, "per-device")) + else if ( !strncmp(s, "per-device", ss - s)) opt_irq_vector_map=OPT_IRQ_VECTOR_MAP_PERDEV; + else + rc = -EINVAL; s = ss + 1; - } while ( ss ); + } while ( *ss ); + + return rc; } /* Must be called when irq disabled */