From patchwork Wed Aug 16 12:52:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9903633 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C3203603B5 for ; Wed, 16 Aug 2017 12:54:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B555A289CD for ; Wed, 16 Aug 2017 12:54:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AA20C289E0; Wed, 16 Aug 2017 12:54:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3D89A289DD for ; Wed, 16 Aug 2017 12:54:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoJ-00007A-Jg; Wed, 16 Aug 2017 12:52:35 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoI-0008SV-1O for xen-devel@lists.xenproject.org; Wed, 16 Aug 2017 12:52:34 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id A4/3E-02177-11044995; Wed, 16 Aug 2017 12:52:33 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRWlGSWpSXmKPExsVyuP0Ov66Aw5R Ig73fDC2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ow//1ezF6zjqlh2ZDlrA+M0ji5GTg4JASOJ txP/MYHYQgILGSWmnPICsdkEVCU2XD/FCmKLCChJ3Fs1GayGWcBdYuO7JhYQW1igSOL46qtgN gtQ/drLd8BqeAVMJL6f6GSBmC8v0XFgMpjNCRSfvOEYC8QuY4ntPY3sExi5FzAyrGJUL04tKk st0jXRSyrKTM8oyU3MzNE1NDDVy00tLk5MT81JTCrWS87P3cQI9C0DEOxgvNXnfIhRkoNJSZQ 3SGtKpBBfUn5KZUZicUZ8UWlOavEhRhkODiUJXkl7oJxgUWp6akVaZg4wyGDSEhw8SiK8abZA ad7igsTc4sx0iNQpRl2OVxP+f2MSYsnLz0uVEufNtAMqEgApyijNgxsBC/hLjLJSwryMQEcJ8 RSkFuVmlqDKv2IU52BUEua9CjKFJzOvBG7TK6AjmICOuNI+CeSIkkSElFQD475gCy1fhXLZUm /FULuz6cxdX+u2nP97I3H7uzuSJZOK7d9v7PP79GNOpdTPH1JCgfn5Is2HLr76UNqw4ZoRz+o jJjLVxSH3t/xua6xs1WN2ZlpwdPaLYzGWq49e+VdXHMTs99qJ2SpD/fih557miz9+eOopVnFy V+uU4k+nM1s36Jx0mfAtX4mlOCPRUIu5qDgRALivpxdzAgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-9.tower-206.messagelabs.com!1502887952!107634112!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28026 invoked from network); 16 Aug 2017 12:52:32 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-9.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 16 Aug 2017 12:52:32 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 74228AEA9; Wed, 16 Aug 2017 12:52:32 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 16 Aug 2017 14:52:03 +0200 Message-Id: <20170816125219.5255-37-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170816125219.5255-1-jgross@suse.com> References: <20170816125219.5255-1-jgross@suse.com> Cc: Juergen Gross , Kevin Tian Subject: [Xen-devel] [PATCH v3 36/52] xen/drivers/passthrough/vtd/quirks.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/drivers/passthrough/vtd/quirks.c to indicate whether the parameter value was parsed successfully. Cc: Kevin Tian Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/drivers/passthrough/vtd/quirks.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c index 5bbbd96d51..4e61ac9ddb 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -247,9 +247,10 @@ void vtd_ops_postamble_quirk(struct iommu* iommu) } } -static void __init parse_snb_timeout(const char *s) +static int __init parse_snb_timeout(const char *s) { int t; + const char *q = NULL; t = parse_bool(s); if ( t < 0 ) @@ -259,13 +260,13 @@ static void __init parse_snb_timeout(const char *s) else if ( strcmp(s, "cap") == 0 ) t = SNB_IGD_TIMEOUT; else - t = strtoul(s, NULL, 0); + t = strtoul(s, &q, 0); } else t = t ? SNB_IGD_TIMEOUT_LEGACY : 0; snb_igd_timeout = MILLISECS(t); - return; + return (q && *q) ? -EINVAL : 0; } custom_param("snb_igd_quirk", parse_snb_timeout);