From patchwork Wed Aug 16 12:52:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9903641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C9F8B6038C for ; Wed, 16 Aug 2017 12:54:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BBDFB289CD for ; Wed, 16 Aug 2017 12:54:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B0C78289E2; Wed, 16 Aug 2017 12:54:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3E1F3289CD for ; Wed, 16 Aug 2017 12:54:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoL-0000Cc-4K; Wed, 16 Aug 2017 12:52:37 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoK-00007a-5k for xen-devel@lists.xenproject.org; Wed, 16 Aug 2017 12:52:36 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id 9D/E9-01731-31044995; Wed, 16 Aug 2017 12:52:35 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ov66Qw5R Ig8eL9C2+b5nM5MDocfjDFZYAxijWzLyk/IoE1owHP64zF9znrfh0ZhFzA+Ntri5GTg4JASOJ txP/MXUxcnEICSxklPhxrYEVJMEmoCqx4fopMFtEQEni3qrJYEXMArMYJZZtns0IkhAWiJb40 LqYCcRmAWpYMGU2G4jNK2Ai0db8gQ1ig7xEx4HJLCA2J1B88oZjYLaQgLHE9p5G9gmM3AsYGV YxqhenFpWlFuka6yUVZaZnlOQmZuboGhqY6uWmFhcnpqfmJCYV6yXn525iBPqXAQh2MO7953S IUZKDSUmUN0hrSqQQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd5FdkA5waLU9NSKtMwcYKDBpCU4 eJREeNNsgdK8xQWJucWZ6RCpU4y6HK8m/P/GJMSSl5+XKiXOmwkyQwCkKKM0D24ELOgvMcpKC fMyAh0lxFOQWpSbWYIq/4pRnINRSZj3KsgUnsy8ErhNr4COYAI64kr7JJAjShIRUlINjHt5Ny xb/2pWXWbVCll/ttb5S040rDDrnm35RoG3fskE409RKr+PMa19ppuV9EQhP6/mUmqH4+lvXat kTvoxfrILmd0adC8zkUk/fTVj89VlXrmbFl1clVv4c1vXCoY/kyYfOMqffH5rUIRNuqXy0vM2 Zft2HzW/b/E8s/Bp2sG7T02fTYwwLVViKc5INNRiLipOBAACJREEdQIAAA== X-Env-Sender: jgross@suse.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1502887954!104683447!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 50927 invoked from network); 16 Aug 2017 12:52:34 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-6.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 16 Aug 2017 12:52:34 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 70F3BAE71; Wed, 16 Aug 2017 12:52:34 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 16 Aug 2017 14:52:09 +0200 Message-Id: <20170816125219.5255-43-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170816125219.5255-1-jgross@suse.com> References: <20170816125219.5255-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Paul Durrant , Jan Beulich Subject: [Xen-devel] [PATCH v3 42/52] xen/arch/x86/hvm/viridian.c: remove custom_param() error messages X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by parse_viridian_version() can be removed. Cc: Paul Durrant Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant --- xen/arch/x86/hvm/viridian.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c index 2edf9d0b23..e0546f32fc 100644 --- a/xen/arch/x86/hvm/viridian.c +++ b/xen/arch/x86/hvm/viridian.c @@ -1104,7 +1104,7 @@ static int __init parse_viridian_version(const char *arg) { n[i] = simple_strtoul(arg, &e, 0); if ( e != t ) - goto fail; + break; } i++; @@ -1112,12 +1112,12 @@ static int __init parse_viridian_version(const char *arg) } while ( *t ); if ( i != 3 ) - goto fail; + return -EINVAL; if ( ((typeof(viridian_major))n[0] != n[0]) || ((typeof(viridian_minor))n[1] != n[1]) || ((typeof(viridian_build))n[2] != n[2]) ) - goto fail; + return -EINVAL; viridian_major = n[0]; viridian_minor = n[1]; @@ -1126,10 +1126,6 @@ static int __init parse_viridian_version(const char *arg) printk("viridian-version = %#x,%#x,%#x\n", viridian_major, viridian_minor, viridian_build); return 0; - - fail: - printk(XENLOG_WARNING "Invalid viridian-version, using default\n"); - return -EINVAL; } custom_param("viridian-version", parse_viridian_version);