From patchwork Wed Aug 16 12:51:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9903653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85EF86038C for ; Wed, 16 Aug 2017 12:54:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 787C3289DD for ; Wed, 16 Aug 2017 12:54:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D7F7289E1; Wed, 16 Aug 2017 12:54:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1DAE7289DD for ; Wed, 16 Aug 2017 12:54:44 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoA-0008H3-OH; Wed, 16 Aug 2017 12:52:26 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxo9-0008GC-Av for xen-devel@lists.xenproject.org; Wed, 16 Aug 2017 12:52:25 +0000 Received: from [193.109.254.147] by server-5.bemta-6.messagelabs.com id 23/E2-03368-80044995; Wed, 16 Aug 2017 12:52:24 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ovy6Hw5R IgxXHuCy+b5nM5MDocfjDFZYAxijWzLyk/IoE1ox5zduZCx5xV7w7f4q1gfEqZxcjJ4eEgJHE 24n/mLoYuTiEBBYySnyZu4YRJMEmoCqx4fopVhBbREBJ4t6qyUwgNrNAocTJ7j6wuLBAosSUS XPB6lmA6q99nQoW5xUwlphy+TEzxAJ5iY4Dk1lAbE4BE4nJG46B2UJANdt7GtknMHIvYGRYxa hRnFpUllqka2ikl1SUmZ5RkpuYmaNraGCml5taXJyYnpqTmFSsl5yfu4kR6F8GINjBeHljwCF GSQ4mJVHeIK0pkUJ8SfkplRmJxRnxRaU5qcWHGGU4OJQkeBfZAeUEi1LTUyvSMnOAgQaTluDg URLhTbMFSvMWFyTmFmemQ6ROMepyvJrw/xuTEEtefl6qlDhvJsgMAZCijNI8uBGwoL/EKCslz MsIdJQQT0FqUW5mCar8K0ZxDkYlYd7ZIFN4MvNK4Da9AjqCCeiIK+2TQI4oSURISTUwrg08WX ZuvvWh+Fu8HAufiyxhz+KsufKzalbp+/bkpZM3/qveZ/vco2vT3AXvYpvVHFum/Xgy+VGu7U6 dnw8v26l6c63hkGnZ3q39dGtm4QIT05UPoyPuhN/85rFlTZ76oiy+mq3xv16fNF/f2HJR1Eyd 44SvYlL8wrD53Gl71Nv617y04dc4qsRSnJFoqMVcVJwIAIDW7aR1AgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-9.tower-27.messagelabs.com!1502887943!112165965!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8662 invoked from network); 16 Aug 2017 12:52:24 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-9.tower-27.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 16 Aug 2017 12:52:24 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C7FB2AD88; Wed, 16 Aug 2017 12:52:23 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 16 Aug 2017 14:51:31 +0200 Message-Id: <20170816125219.5255-5-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170816125219.5255-1-jgross@suse.com> References: <20170816125219.5255-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v3 04/52] xen/arch/x86/apic.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/apic.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/apic.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c index 851a6cc6cb..325b48074a 100644 --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -785,23 +785,28 @@ int lapic_resume(void) * Original code written by Keir Fraser. */ -static void __init lapic_disable(char *str) +static int __init lapic_disable(const char *str) { enable_local_apic = -1; setup_clear_cpu_cap(X86_FEATURE_APIC); + return 0; } custom_param("nolapic", lapic_disable); boolean_param("lapic", enable_local_apic); -static void __init apic_set_verbosity(char *str) +static int __init apic_set_verbosity(const char *str) { if (strcmp("debug", str) == 0) apic_verbosity = APIC_DEBUG; else if (strcmp("verbose", str) == 0) apic_verbosity = APIC_VERBOSE; - else + else { printk(KERN_WARNING "APIC Verbosity level %s not recognised" " use apic_verbosity=verbose or apic_verbosity=debug", str); + return -EINVAL; + } + + return 0; } custom_param("apic_verbosity", apic_set_verbosity);