From patchwork Wed Aug 16 12:51:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9903647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C80336038C for ; Wed, 16 Aug 2017 12:54:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9A71289CD for ; Wed, 16 Aug 2017 12:54:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AEB52289E0; Wed, 16 Aug 2017 12:54:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6566A289CD for ; Wed, 16 Aug 2017 12:54:40 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoA-0008HF-V3; Wed, 16 Aug 2017 12:52:26 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxo9-0008Fz-B5 for xen-devel@lists.xenproject.org; Wed, 16 Aug 2017 12:52:25 +0000 Received: from [193.109.254.147] by server-8.bemta-6.messagelabs.com id B1/3C-09901-90044995; Wed, 16 Aug 2017 12:52:25 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRWlGSWpSXmKPExsVyuP0Ovy6Hw5R Ig4nTFCy+b5nM5MDocfjDFZYAxijWzLyk/IoE1oy+S4vYCmbxVZw9I9TAeJu7i5GTQ0LASOLt xH9MXYxcHEICCxklXp1pYgNJsAmoSmy4fooVxBYRUJK4t2oyE4jNLFAocbK7DywuLJAqcfbsD RYQmwWo/v7MDmYQm1fAWKLn/mM2iAXyEh0HJoPVcAqYSEzecAzMFgKq2d7TyD6BkXsBI8MqRo 3i1KKy1CJdIwO9pKLM9IyS3MTMHF1DAzO93NTi4sT01JzEpGK95PzcTYxA7zIAwQ7GX8sCDjF KcjApifIGaU2JFOJLyk+pzEgszogvKs1JLT7EKMPBoSTBu8gOKCdYlJqeWpGWmQMMM5i0BAeP kghvmi1Qmre4IDG3ODMdInWKUZfj1YT/35iEWPLy81KlxHlvgcwQACnKKM2DGwEL+UuMslLCv IxARwnxFKQW5WaWoMq/YhTnYFQS5p0NMoUnM68EbtMroCOYgI640j4J5IiSRISUVAOjzKakvA VLbgQ8XLN8Xlzyu4oTCnKJqnZKS1ZbxTmvMss48H+/17rozS0ewXN2O2gtkNi54uerxlg9pas 35xoUvA+X37r/Uv6c4NlTWA+yhwheX+XjyRESzqEnsOyTz+Ozr62bRS8d3OHwvci7Z/6WU2Ez ur8HbZyZ1cy0Onr98S8LpZU0pOrjlFiKMxINtZiLihMB40qSunQCAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1502887944!107474251!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17581 invoked from network); 16 Aug 2017 12:52:24 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-7.tower-27.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 16 Aug 2017 12:52:24 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 21639AE8B; Wed, 16 Aug 2017 12:52:24 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 16 Aug 2017 14:51:33 +0200 Message-Id: <20170816125219.5255-7-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170816125219.5255-1-jgross@suse.com> References: <20170816125219.5255-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v3 06/52] xen/arch/x86/cpu/vpmu.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/cpu/vpmu.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/cpu/vpmu.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index 90954ca884..e0c87a68d4 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -53,7 +53,7 @@ CHECK_pmu_params; static unsigned int __read_mostly opt_vpmu_enabled; unsigned int __read_mostly vpmu_mode = XENPMU_MODE_OFF; unsigned int __read_mostly vpmu_features = 0; -static void parse_vpmu_params(char *s); +static int parse_vpmu_params(const char *s); custom_param("vpmu", parse_vpmu_params); static DEFINE_SPINLOCK(vpmu_lock); @@ -61,7 +61,7 @@ static unsigned vpmu_count; static DEFINE_PER_CPU(struct vcpu *, last_vcpu); -static int parse_vpmu_param(char *s, unsigned int len) +static int parse_vpmu_param(const char *s, unsigned int len) { if ( !*s || !len ) return 0; @@ -76,9 +76,9 @@ static int parse_vpmu_param(char *s, unsigned int len) return 0; } -static void __init parse_vpmu_params(char *s) +static int __init parse_vpmu_params(const char *s) { - char *sep, *p = s; + const char *sep, *p = s; switch ( parse_bool(s) ) { @@ -104,10 +104,11 @@ static void __init parse_vpmu_params(char *s) opt_vpmu_enabled = 1; break; } - return; + return 0; error: printk("VPMU: unknown flags: %s - vpmu disabled!\n", s); + return -EINVAL; } void vpmu_lvtpc_update(uint32_t val)