From patchwork Wed Aug 16 12:51:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9903667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 294586038C for ; Wed, 16 Aug 2017 12:54:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1AF75289CD for ; Wed, 16 Aug 2017 12:54:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0FCAA289E0; Wed, 16 Aug 2017 12:54:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C18A4289CD for ; Wed, 16 Aug 2017 12:54:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoB-0008IA-NN; Wed, 16 Aug 2017 12:52:27 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxoA-0008Gr-8f for xen-devel@lists.xenproject.org; Wed, 16 Aug 2017 12:52:26 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 0D/A3-02176-90044995; Wed, 16 Aug 2017 12:52:25 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRWlGSWpSXmKPExsVyuP0Ovy6Hw5R Ig4fnLS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozjU98yF8znqNj24DljA2MzexcjJ4eEgJHE 24n/mLoYuTiEBBYySqy8cxkswSagKrHh+ilWEFtEQEni3qrJTCA2s0ChxMnuPrC4sECWxJfub jYQmwWo/v3Tq2C9vALGEt9uvWaCWCAv0XFgMguIzSlgIjF5wzEwWwioZntPI/sERu4FjAyrGN WLU4vKUot0LfWSijLTM0pyEzNzdA0NTPVyU4uLE9NTcxKTivWS83M3MQK9ywAEOxjXtjofYpT kYFIS5Q3SmhIpxJeUn1KZkVicEV9UmpNafIhRhoNDSYJ3kR1QTrAoNT21Ii0zBxhmMGkJDh4l Ed40W6A0b3FBYm5xZjpE6hSjLserCf+/MQmx5OXnpUqJ82aCzBAAKcoozYMbAQv5S4yyUsK8j EBHCfEUpBblZpagyr9iFOdgVBLmvQoyhSczrwRu0yugI5iAjrjSPgnkiJJEhJRUA6P1rLcCV5 YWHPPjXb5YhbFwhfnchaELghUOXzf1kYiq9z7NzPlXIGBl7ocNCRs/uf5M71c0cbg42VCJX3b /vQWla7VmC79/3Z23bJ5X4o+TDREV2ROfrpv6xPVA1+c7TlfWTl4XLLava+JTbkWfjwdOLDm4 Mz3KjI2p8PV/2dXmDbdS68PY3eyUWIozEg21mIuKEwFdBmJvdAIAAA== X-Env-Sender: jgross@suse.com X-Msg-Ref: server-8.tower-206.messagelabs.com!1502887944!107381992!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15153 invoked from network); 16 Aug 2017 12:52:24 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-8.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 16 Aug 2017 12:52:24 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 96A24AE94; Wed, 16 Aug 2017 12:52:24 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 16 Aug 2017 14:51:35 +0200 Message-Id: <20170816125219.5255-9-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170816125219.5255-1-jgross@suse.com> References: <20170816125219.5255-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v3 08/52] xen/arch/x86/genapic/probe.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/genapic/probe.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V3: - dont return out of loop (Jan Beulich) --- xen/arch/x86/genapic/probe.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/genapic/probe.c b/xen/arch/x86/genapic/probe.c index 9a147ff64a..af3745aa21 100644 --- a/xen/arch/x86/genapic/probe.c +++ b/xen/arch/x86/genapic/probe.c @@ -44,12 +44,17 @@ void __init generic_bigsmp_probe(void) } } -static void __init genapic_apic_force(char *str) +static int __init genapic_apic_force(const char *str) { - int i; + int i, rc = -EINVAL; + for (i = 0; apic_probe[i]; i++) - if (!strcmp(apic_probe[i]->name, str)) + if (!strcmp(apic_probe[i]->name, str)) { genapic = apic_probe[i]; + rc = 0; + } + + return rc; } custom_param("apic", genapic_apic_force);