From patchwork Thu Aug 17 14:44:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Liu X-Patchwork-Id: 9906491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B8DB6038C for ; Thu, 17 Aug 2017 14:47:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D1DF28B2C for ; Thu, 17 Aug 2017 14:47:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71FA028B2F; Thu, 17 Aug 2017 14:47:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD21E28B2C for ; Thu, 17 Aug 2017 14:47:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diM3L-0001Cs-F4; Thu, 17 Aug 2017 14:45:43 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diM3K-0001Aq-Mh for xen-devel@lists.xenproject.org; Thu, 17 Aug 2017 14:45:42 +0000 Received: from [85.158.139.211] by server-16.bemta-5.messagelabs.com id 84/3F-01712-61CA5995; Thu, 17 Aug 2017 14:45:42 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRWlGSWpSXmKPExsXitHSDva7omqm RBrNPK1l83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBlv1/YyFpzVq3j1+ytbA2OzchcjB4eEgL/E m33MXYycHGwCyhI/O3vZQGwRAT2JpgPPGbsYuTiYBeYwSkyd28UIkhAWCJToe7eSFcRmEVCV+ Hb4NVicV8BC4sjK52C2hIC8xK62i2A1nAKWEocmLQZbIARUM/tDOzuErSDRMf0YE0SvoMTJmU 9YQGxmAQmJgy9eME9g5J2FJDULSWoBI9MqRo3i1KKy1CJdIwu9pKLM9IyS3MTMHF1DA1O93NT i4sT01JzEpGK95PzcTYzA4KlnYGDcwdi3yu8QoyQHk5Io7+9ZUyKF+JLyUyozEosz4otKc1KL DzFqcHAI9K1ZfYFRiiUvPy9VSYL38aqpkUKCRanpqRVpmTnA8IYpleDgURLhtVgNlOYtLkjML c5Mh0idYjTmWNCz4QsTx6sJ/78xCYFNkhLnjQQpFQApzSjNgxsEi7tLjLJSwryMDAwMQjwFqU W5mSWo8q8YxTkYlYR5fUGm8GTmlcDtewV0ChPQKVfaJ4GcUpKIkJJqYMx/+7jp8Lzqm68XSOx ZYKEmprXvglO7x3qu8PTlNz4mlV6SO/9NrjXXyt3MTz+cSVRj2881t2Z7m66rTZSSSFmkuzb8 aMfXN/cfGZicdVV7rHRilWbE0TfHvhwWs355vz2ecXn5RYNbTetnf+tduHZygcuLe6WNknmCr sHLvdOs7WUz30+d0KzEUpyRaKjFXFScCADbDNI8tgIAAA== X-Env-Sender: prvs=395e6b081=wei.liu2@citrix.com X-Msg-Ref: server-10.tower-206.messagelabs.com!1502981139!79283524!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 48035 invoked from network); 17 Aug 2017 14:45:41 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-10.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 17 Aug 2017 14:45:41 -0000 X-IronPort-AV: E=Sophos;i="5.41,388,1498521600"; d="scan'208";a="444178355" From: Wei Liu To: Xen-devel Date: Thu, 17 Aug 2017 15:44:28 +0100 Message-ID: <20170817144456.18989-4-wei.liu2@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170817144456.18989-1-wei.liu2@citrix.com> References: <20170817144456.18989-1-wei.liu2@citrix.com> MIME-Version: 1.0 Cc: George Dunlap , Andrew Cooper , Wei Liu , Jan Beulich Subject: [Xen-devel] [PATCH v4 03/31] x86/mm: split HVM grant table code to hvm/grant_table.c X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/hvm/Makefile | 1 + xen/arch/x86/hvm/grant_table.c | 89 ++++++++++++++++++++++++++++++++++++++++++ xen/arch/x86/mm.c | 53 ------------------------- 3 files changed, 90 insertions(+), 53 deletions(-) create mode 100644 xen/arch/x86/hvm/grant_table.c diff --git a/xen/arch/x86/hvm/Makefile b/xen/arch/x86/hvm/Makefile index c394af7364..5bd38f633f 100644 --- a/xen/arch/x86/hvm/Makefile +++ b/xen/arch/x86/hvm/Makefile @@ -6,6 +6,7 @@ obj-y += dm.o obj-bin-y += dom0_build.init.o obj-y += domain.o obj-y += emulate.o +obj-y += grant_table.o obj-y += hpet.o obj-y += hvm.o obj-y += hypercall.o diff --git a/xen/arch/x86/hvm/grant_table.c b/xen/arch/x86/hvm/grant_table.c new file mode 100644 index 0000000000..7503c2c61b --- /dev/null +++ b/xen/arch/x86/hvm/grant_table.c @@ -0,0 +1,89 @@ +/****************************************************************************** + * arch/x86/hvm/grant_table.c + * + * Grant table interfaces for HVM guests + * + * Copyright (C) 2017 Wei Liu + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; If not, see . + */ + +#include + +#include + +#include + +int create_grant_p2m_mapping(uint64_t addr, unsigned long frame, + unsigned int flags, + unsigned int cache_flags) +{ + p2m_type_t p2mt; + int rc; + + if ( cache_flags || (flags & ~GNTMAP_readonly) != GNTMAP_host_map ) + return GNTST_general_error; + + if ( flags & GNTMAP_readonly ) + p2mt = p2m_grant_map_ro; + else + p2mt = p2m_grant_map_rw; + rc = guest_physmap_add_entry(current->domain, + _gfn(addr >> PAGE_SHIFT), + _mfn(frame), PAGE_ORDER_4K, p2mt); + if ( rc ) + return GNTST_general_error; + else + return GNTST_okay; +} + +int replace_grant_p2m_mapping(uint64_t addr, unsigned long frame, + uint64_t new_addr, unsigned int flags) +{ + unsigned long gfn = (unsigned long)(addr >> PAGE_SHIFT); + p2m_type_t type; + mfn_t old_mfn; + struct domain *d = current->domain; + + if ( new_addr != 0 || (flags & GNTMAP_contains_pte) ) + return GNTST_general_error; + + old_mfn = get_gfn(d, gfn, &type); + if ( !p2m_is_grant(type) || mfn_x(old_mfn) != frame ) + { + put_gfn(d, gfn); + gdprintk(XENLOG_WARNING, + "old mapping invalid (type %d, mfn %" PRI_mfn ", frame %lx)\n", + type, mfn_x(old_mfn), frame); + return GNTST_general_error; + } + if ( guest_physmap_remove_page(d, _gfn(gfn), _mfn(frame), PAGE_ORDER_4K) ) + { + put_gfn(d, gfn); + return GNTST_general_error; + } + + put_gfn(d, gfn); + return GNTST_okay; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index d7d04772c5..5c6a7e5638 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4017,29 +4017,6 @@ static int destroy_grant_va_mapping( return replace_grant_va_mapping(addr, frame, l1e_empty(), v); } -int create_grant_p2m_mapping(uint64_t addr, unsigned long frame, - unsigned int flags, - unsigned int cache_flags) -{ - p2m_type_t p2mt; - int rc; - - if ( cache_flags || (flags & ~GNTMAP_readonly) != GNTMAP_host_map ) - return GNTST_general_error; - - if ( flags & GNTMAP_readonly ) - p2mt = p2m_grant_map_ro; - else - p2mt = p2m_grant_map_rw; - rc = guest_physmap_add_entry(current->domain, - _gfn(addr >> PAGE_SHIFT), - _mfn(frame), PAGE_ORDER_4K, p2mt); - if ( rc ) - return GNTST_general_error; - else - return GNTST_okay; -} - int create_grant_pv_mapping(uint64_t addr, unsigned long frame, unsigned int flags, unsigned int cache_flags) { @@ -4068,36 +4045,6 @@ int create_grant_pv_mapping(uint64_t addr, unsigned long frame, return create_grant_va_mapping(addr, pte, current); } -int replace_grant_p2m_mapping( - uint64_t addr, unsigned long frame, uint64_t new_addr, unsigned int flags) -{ - unsigned long gfn = (unsigned long)(addr >> PAGE_SHIFT); - p2m_type_t type; - mfn_t old_mfn; - struct domain *d = current->domain; - - if ( new_addr != 0 || (flags & GNTMAP_contains_pte) ) - return GNTST_general_error; - - old_mfn = get_gfn(d, gfn, &type); - if ( !p2m_is_grant(type) || mfn_x(old_mfn) != frame ) - { - put_gfn(d, gfn); - gdprintk(XENLOG_WARNING, - "old mapping invalid (type %d, mfn %" PRI_mfn ", frame %lx)\n", - type, mfn_x(old_mfn), frame); - return GNTST_general_error; - } - if ( guest_physmap_remove_page(d, _gfn(gfn), _mfn(frame), PAGE_ORDER_4K) ) - { - put_gfn(d, gfn); - return GNTST_general_error; - } - - put_gfn(d, gfn); - return GNTST_okay; -} - int replace_grant_pv_mapping(uint64_t addr, unsigned long frame, uint64_t new_addr, unsigned int flags) {