diff mbox

[stage1-xen,(RFC),07/10] .circleci/config.yml: Add

Message ID 20170821071825.65172.26164.stgit@rajivs-macbook-pro.local (mailing list archive)
State New, archived
Headers show

Commit Message

Rajiv Ranganath Aug. 21, 2017, 7:18 a.m. UTC
From: Rajiv M Ranganath <rajiv.ranganath@atihita.com>


---
 .circleci/config.yml |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 .circleci/config.yml

Comments

Stefano Stabellini Aug. 24, 2017, 12:24 a.m. UTC | #1
On Mon, 21 Aug 2017, Rajiv Ranganath wrote:
> From: Rajiv M Ranganath <rajiv.ranganath@atihita.com>

Does .circleci need to be in the top directory or could it be under
fedora? If possible, I think it would make more sense to introduce it
there.

> 
> ---
>  .circleci/config.yml |   21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 .circleci/config.yml
> 
> diff --git a/.circleci/config.yml b/.circleci/config.yml
> new file mode 100644
> index 0000000..67ac964
> --- /dev/null
> +++ b/.circleci/config.yml
> @@ -0,0 +1,21 @@
> +version: 2
> +jobs:
> +  build:
> +    working_directory: /root
> +    docker:
> +      - image: lambdalinuxfedora/stage1-xen-fedora-buildroot:1708171409
> +        command: /sbin/my_init
> +    steps:
> +      - run:
> +          # We create `stage1-xen` directory in Dockerfile for local dev
> +          # environment. Removing it here so CircleCI checkout step can work
> +          # correctly
> +          name: Removing stage1-xen directory from GOPATH...
> +          command: |
> +            rm -rf /root/gopath/src/github.com/rkt/stage1-xen
> +      - checkout:
> +          path: /root/gopath/src/github.com/rkt/stage1-xen
> +      - run:
> +          name: Starting run...
> +          command: |
> +            /root/bin/run
>
Rajiv Ranganath Aug. 24, 2017, 10:39 a.m. UTC | #2
On Thu, Aug 24 2017 at 05:54:05 AM, Stefano Stabellini <sstabellini@kernel.org> wrote:
> On Mon, 21 Aug 2017, Rajiv Ranganath wrote:
>> From: Rajiv M Ranganath <rajiv.ranganath@atihita.com>
>
> Does .circleci need to be in the top directory or could it be under
> fedora? If possible, I think it would make more sense to introduce it
> there.
>

I would have also preferred the `.circleci/` directory to be under
`build/fedora/`.

However, I could not find an option to change this directory. From their
documentation [1], I get a sense that this path is hardcoded.

Best,
Rajiv

[1]: https://circleci.com/docs/2.0/configuration-reference/
Stefano Stabellini Aug. 25, 2017, 12:56 a.m. UTC | #3
On Thu, 24 Aug 2017, Rajiv Ranganath wrote:
> On Thu, Aug 24 2017 at 05:54:05 AM, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > On Mon, 21 Aug 2017, Rajiv Ranganath wrote:
> >> From: Rajiv M Ranganath <rajiv.ranganath@atihita.com>
> >
> > Does .circleci need to be in the top directory or could it be under
> > fedora? If possible, I think it would make more sense to introduce it
> > there.
> >
> 
> I would have also preferred the `.circleci/` directory to be under
> `build/fedora/`.
> 
> However, I could not find an option to change this directory. From their
> documentation [1], I get a sense that this path is hardcoded.

Oh well. In that case, we'll keep it in the root directory. Thanks for
checking.
diff mbox

Patch

diff --git a/.circleci/config.yml b/.circleci/config.yml
new file mode 100644
index 0000000..67ac964
--- /dev/null
+++ b/.circleci/config.yml
@@ -0,0 +1,21 @@ 
+version: 2
+jobs:
+  build:
+    working_directory: /root
+    docker:
+      - image: lambdalinuxfedora/stage1-xen-fedora-buildroot:1708171409
+        command: /sbin/my_init
+    steps:
+      - run:
+          # We create `stage1-xen` directory in Dockerfile for local dev
+          # environment. Removing it here so CircleCI checkout step can work
+          # correctly
+          name: Removing stage1-xen directory from GOPATH...
+          command: |
+            rm -rf /root/gopath/src/github.com/rkt/stage1-xen
+      - checkout:
+          path: /root/gopath/src/github.com/rkt/stage1-xen
+      - run:
+          name: Starting run...
+          command: |
+            /root/bin/run