From patchwork Fri Aug 25 16:43:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Dunlap X-Patchwork-Id: 9922491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 284FC603FA for ; Fri, 25 Aug 2017 16:46:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19068281D2 for ; Fri, 25 Aug 2017 16:46:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DF82283CF; Fri, 25 Aug 2017 16:46:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B4CE0283CB for ; Fri, 25 Aug 2017 16:46:19 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlHiG-000562-QX; Fri, 25 Aug 2017 16:44:04 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlHiF-00053Q-TH for xen-devel@lists.xenproject.org; Fri, 25 Aug 2017 16:44:04 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id 95/64-02177-3D350A95; Fri, 25 Aug 2017 16:44:03 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeJIrShJLcpLzFFi42JxWrrBXvdi8IJ Ig4VbNS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozWp/sZC1r4Ks79PszewHiBu4uRk0NCwF/i xYnNrCA2m4CexLzjX1m6GDk4RARUJG7vNehi5OJgFtjPKNH79QcbSFxYIEbi66s8kHIWAVWJg 3unMIHYvAK2EmvfnWCEGCkvce7BbWaQck4BO4ldJ7lATCGgkhdn9EAqhIA6Fz84yg7RKShxcu YTFhCbWUBC4uCLF8wTGHlnIUnNQpJawMi0ilGjOLWoLLVI19BEL6koMz2jJDcxM0fX0MBULze 1uDgxPTUnMalYLzk/dxMjMGwYgGAH49nTnocYJTmYlER5rV/OjxTiS8pPqcxILM6ILyrNSS0+ xCjDwaEkwTshaEGkkGBRanpqRVpmDjCAYdISHDxKIrxtIGne4oLE3OLMdIjUKUZFKXHeUpCEA EgiozQPrg0WNZcYZaWEeRmBDhHiKUgtys0sQZV/xSjOwagkzGsLMoUnM68EbvoroMVMQIsnnZ gDsrgkESEl1cA4h+2Ud06lR1o7W+/rpTauTtvOKhZqSlRwzD8/ecXUv52OJgq6+hs1l/38Vix zcLZ67q67D85PSavam9/Bo9FifGpp8d+IWse/tXVfNcIcPvf5xvjvNVKeuMGNR7Ve/fe2zAc6 s3Jbzv7NX5bpNS3z2bSwe1cu/f0g6F76mmWT3erLdxau3LJYiaU4I9FQi7moOBEAHDo98JUCA AA= X-Env-Sender: prvs=4030414b0=George.Dunlap@citrix.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1503679439!94886250!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 48458 invoked from network); 25 Aug 2017 16:44:01 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-15.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 25 Aug 2017 16:44:01 -0000 X-IronPort-AV: E=Sophos;i="5.41,426,1498521600"; d="scan'208";a="445163895" From: George Dunlap To: Date: Fri, 25 Aug 2017 17:43:34 +0100 Message-ID: <20170825164343.29015-5-george.dunlap@citrix.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170825164343.29015-1-george.dunlap@citrix.com> References: <20170825164343.29015-1-george.dunlap@citrix.com> MIME-Version: 1.0 Cc: Ian Jackson , Wei Liu , George Dunlap , Jan Beulich , Andrew Cooper Subject: [Xen-devel] [PATCH 05/14] fuzz/x86_emulate: Improve failure descriptions in x86_emulate harness X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP - Print the symbolic name rather than the number - Explicitly state when data_read() fails due to EOI Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper CC: Jan Beulich --- tools/fuzz/x86_instruction_emulator/fuzz-emul.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c index 48a879cc88..7f9a369421 100644 --- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c +++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c @@ -52,6 +52,14 @@ struct fuzz_state struct x86_emulate_ops ops; }; +char *x86emul_return_string[] = { + [X86EMUL_OKAY]="X86EMUL_OKAY", + [X86EMUL_UNHANDLEABLE]="X86EMUL_UNHANDLEABLE", + [X86EMUL_EXCEPTION]="X86EMUL_EXCEPTION", + [X86EMUL_RETRY]="X86EMUL_RETRY", + [X86EMUL_DONE]="X86EMUL_DONE", +}; + /* * Randomly return success or failure when processing data. If * `exception` is false, this function turns _EXCEPTION to _OKAY. @@ -84,7 +92,7 @@ static int maybe_fail(struct x86_emulate_ctxt *ctxt, if ( rc == X86EMUL_EXCEPTION && !exception ) rc = X86EMUL_OKAY; - printf("maybe_fail %s: %d\n", why, rc); + printf("maybe_fail %s: %s\n", why, x86emul_return_string[rc]); if ( rc == X86EMUL_EXCEPTION ) /* Fake up a pagefault. */ @@ -113,6 +121,7 @@ static int data_read(struct x86_emulate_ctxt *ctxt, x86_emul_hw_exception(13, 0, ctxt); rc = X86EMUL_EXCEPTION; + printf("data_read %s: X86EMUL_EXCEPTION (end of input)\n", why); } else rc = maybe_fail(ctxt, why, true);