From patchwork Thu Aug 31 09:36:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 9931695 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EDDDD60362 for ; Thu, 31 Aug 2017 09:48:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA9CE288D9 for ; Thu, 31 Aug 2017 09:48:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CD7F1288DC; Thu, 31 Aug 2017 09:48:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4699E288D9 for ; Thu, 31 Aug 2017 09:48:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnM3X-0000Gg-Ku; Thu, 31 Aug 2017 09:46:35 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnM3W-0000GD-0t for xen-devel@lists.xenproject.org; Thu, 31 Aug 2017 09:46:34 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id 45/21-03414-9FAD7A95; Thu, 31 Aug 2017 09:46:33 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRWlGSWpSXmKPExsXitHSDve6PW8s jDc7/Nbb4vmUykwOjx+EPV1gCGKNYM/OS8isSWDP+tv9lLriuW3H99y/WBsaLyl2MnBwSAv4S 096vYQWx2QR0JKY+vQRkc3CICKhI3N5rABJmFiiXmHd3GhOILSzgLbH87zpGEJtFQFViRsMbs DivgI3Ewy1HmSFGykvsarsINpITKL5kUQNYvZCAtcShlcuYIeoFJU7OfMICMV9TonX7b3YIW1 6ieetsZoh6FYn1U2exTWDkm4WkZRaSlllIWhYwMq9i1ChOLSpLLdI1NNZLKspMzyjJTczM0TU 0MNPLTS0uTkxPzUlMKtZLzs/dxAgMNQYg2MH4ZVnAIUZJDiYlUd6wC8sjhfiS8lMqMxKLM+KL SnNSiw8xynBwKEnw5twEygkWpaanVqRl5gCDHiYtwcGjJMJ7CiTNW1yQmFucmQ6ROsWoKCXOm w+SEABJZJTmwbXBIu0So6yUMC8j0CFCPAWpRbmZJajyrxjFORiVhHnngUzhycwrgZv+CmgxE9 DiWK+lIItLEhFSUg2MckEXVGMezrGtfr+DTXzKThdjjYqPq5KqfmXd8o2wON1VrR3Av/EJZ7f +cmfWAu2fLx/fYDl7zn7zlP2srirzD/Et3F5/N/qG78+Mq6tfeDNa/Zs2xXBq75/0xEe8X42l Tx4y+cSV4erA8Fo/IbRrp1R/i5w2Y0jp3tUK3Ou0I2x2Jn15O2e+EktxRqKhFnNRcSIAKovV+ a8CAAA= X-Env-Sender: prvs=4091fd0e1=Paul.Durrant@citrix.com X-Msg-Ref: server-3.tower-21.messagelabs.com!1504172791!76966806!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 51240 invoked from network); 31 Aug 2017 09:46:32 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-3.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 31 Aug 2017 09:46:32 -0000 X-IronPort-AV: E=Sophos;i="5.41,451,1498521600"; d="scan'208";a="446033477" From: Paul Durrant To: Date: Thu, 31 Aug 2017 10:36:03 +0100 Message-ID: <20170831093605.2757-11-paul.durrant@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170831093605.2757-1-paul.durrant@citrix.com> References: <20170831093605.2757-1-paul.durrant@citrix.com> MIME-Version: 1.0 Cc: Andrew Cooper , Paul Durrant , Jan Beulich Subject: [Xen-devel] [PATCH v3 10/12] x86/hvm/ioreq: use gfn_t in struct hvm_ioreq_page X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch adjusts the ioreq server code to use type-safe gfn_t values where possible. No functional change. Signed-off-by: Paul Durrant Reviewed-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: Jan Beulich --- xen/arch/x86/hvm/ioreq.c | 44 ++++++++++++++++++++-------------------- xen/include/asm-x86/hvm/domain.h | 2 +- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index fac82ae934..48c523825e 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -192,7 +192,7 @@ bool handle_hvm_io_completion(struct vcpu *v) #define IS_DEFAULT(s) \ (s == s->domain->arch.hvm_domain.ioreq_server.server[DEFAULT_IOSERVID]) -static unsigned long hvm_alloc_ioreq_gfn(struct hvm_ioreq_server *s) +static gfn_t hvm_alloc_ioreq_gfn(struct hvm_ioreq_server *s) { struct domain *d = s->domain; unsigned int i; @@ -202,20 +202,19 @@ static unsigned long hvm_alloc_ioreq_gfn(struct hvm_ioreq_server *s) for ( i = 0; i < sizeof(d->arch.hvm_domain.ioreq_gfn.mask) * 8; i++ ) { if ( test_and_clear_bit(i, &d->arch.hvm_domain.ioreq_gfn.mask) ) - return d->arch.hvm_domain.ioreq_gfn.base + i; + return _gfn(d->arch.hvm_domain.ioreq_gfn.base + i); } - return gfn_x(INVALID_GFN); + return INVALID_GFN; } -static void hvm_free_ioreq_gfn(struct hvm_ioreq_server *s, - unsigned long gfn) +static void hvm_free_ioreq_gfn(struct hvm_ioreq_server *s, gfn_t gfn) { struct domain *d = s->domain; - unsigned int i = gfn - d->arch.hvm_domain.ioreq_gfn.base; + unsigned int i = gfn_x(gfn) - d->arch.hvm_domain.ioreq_gfn.base; ASSERT(!IS_DEFAULT(s)); - ASSERT(gfn != gfn_x(INVALID_GFN)); + ASSERT(!gfn_eq(gfn, INVALID_GFN)); set_bit(i, &d->arch.hvm_domain.ioreq_gfn.mask); } @@ -224,7 +223,7 @@ static void hvm_unmap_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) { struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - if ( iorp->gfn == gfn_x(INVALID_GFN) ) + if ( gfn_eq(iorp->gfn, INVALID_GFN) ) return; destroy_ring_for_helper(&iorp->va, iorp->page); @@ -233,7 +232,7 @@ static void hvm_unmap_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) if ( !IS_DEFAULT(s) ) hvm_free_ioreq_gfn(s, iorp->gfn); - iorp->gfn = gfn_x(INVALID_GFN); + iorp->gfn = INVALID_GFN; } static int hvm_map_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) @@ -246,16 +245,17 @@ static int hvm_map_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) return -EINVAL; if ( IS_DEFAULT(s) ) - iorp->gfn = buf ? - d->arch.hvm_domain.params[HVM_PARAM_BUFIOREQ_PFN] : - d->arch.hvm_domain.params[HVM_PARAM_IOREQ_PFN]; + iorp->gfn = _gfn(buf ? + d->arch.hvm_domain.params[HVM_PARAM_BUFIOREQ_PFN] : + d->arch.hvm_domain.params[HVM_PARAM_IOREQ_PFN]); else iorp->gfn = hvm_alloc_ioreq_gfn(s); - if ( iorp->gfn == gfn_x(INVALID_GFN) ) + if ( gfn_eq(iorp->gfn, INVALID_GFN) ) return -ENOMEM; - rc = prepare_ring_for_helper(d, iorp->gfn, &iorp->page, &iorp->va); + rc = prepare_ring_for_helper(d, gfn_x(iorp->gfn), &iorp->page, + &iorp->va); if ( rc ) hvm_unmap_ioreq_gfn(s, buf); @@ -297,10 +297,10 @@ static void hvm_remove_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) struct domain *d = s->domain; struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; - if ( IS_DEFAULT(s) || iorp->gfn == gfn_x(INVALID_GFN) ) + if ( IS_DEFAULT(s) || gfn_eq(iorp->gfn, INVALID_GFN) ) return; - if ( guest_physmap_remove_page(d, _gfn(iorp->gfn), + if ( guest_physmap_remove_page(d, iorp->gfn, _mfn(page_to_mfn(iorp->page)), 0) ) domain_crash(d); clear_page(iorp->va); @@ -312,12 +312,12 @@ static int hvm_add_ioreq_gfn(struct hvm_ioreq_server *s, bool buf) struct hvm_ioreq_page *iorp = buf ? &s->bufioreq : &s->ioreq; int rc; - if ( IS_DEFAULT(s) || iorp->gfn == gfn_x(INVALID_GFN) ) + if ( IS_DEFAULT(s) || gfn_eq(iorp->gfn, INVALID_GFN) ) return 0; clear_page(iorp->va); - rc = guest_physmap_add_page(d, _gfn(iorp->gfn), + rc = guest_physmap_add_page(d, iorp->gfn, _mfn(page_to_mfn(iorp->page)), 0); if ( rc == 0 ) paging_mark_dirty(d, _mfn(page_to_mfn(iorp->page))); @@ -576,8 +576,8 @@ static int hvm_ioreq_server_init(struct hvm_ioreq_server *s, INIT_LIST_HEAD(&s->ioreq_vcpu_list); spin_lock_init(&s->bufioreq_lock); - s->ioreq.gfn = gfn_x(INVALID_GFN); - s->bufioreq.gfn = gfn_x(INVALID_GFN); + s->ioreq.gfn = INVALID_GFN; + s->bufioreq.gfn = INVALID_GFN; rc = hvm_ioreq_server_alloc_rangesets(s, id); if ( rc ) @@ -738,11 +738,11 @@ int hvm_get_ioreq_server_info(struct domain *d, ioservid_t id, if ( id >= MAX_NR_IOREQ_SERVERS || !s || IS_DEFAULT(s) ) goto out; - *ioreq_gfn = s->ioreq.gfn; + *ioreq_gfn = gfn_x(s->ioreq.gfn); if ( s->bufioreq.va != NULL ) { - *bufioreq_gfn = s->bufioreq.gfn; + *bufioreq_gfn = gfn_x(s->bufioreq.gfn); *bufioreq_port = s->bufioreq_evtchn; } diff --git a/xen/include/asm-x86/hvm/domain.h b/xen/include/asm-x86/hvm/domain.h index 01fe8a72d8..2be9353e37 100644 --- a/xen/include/asm-x86/hvm/domain.h +++ b/xen/include/asm-x86/hvm/domain.h @@ -36,7 +36,7 @@ #include struct hvm_ioreq_page { - unsigned long gfn; + gfn_t gfn; struct page_info *page; void *va; };