| Message ID | 20170831151004.93710-1-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 31.08.17 at 17:10, <roger.pau@citrix.com> wrote: > Changes since v1: > - Completely remove the comment, HVM guests also use > vcpu_hvm_context instead of vcpu_guest_context. Are you sure? Specifically for ... > --- a/xen/include/public/arch-x86/xen.h > +++ b/xen/include/public/arch-x86/xen.h > @@ -161,15 +161,6 @@ typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */ > /* > * The following is all CPU context. Note that the fpu_ctxt block is filled > * in by FXSAVE if the CPU has feature FXSR; otherwise FSAVE is used. > - * > - * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise ... the DOMCTL_setvcpucontext part. Jan
On Thu, Aug 31, 2017 at 09:16:35AM -0600, Jan Beulich wrote: > >>> On 31.08.17 at 17:10, <roger.pau@citrix.com> wrote: > > Changes since v1: > > - Completely remove the comment, HVM guests also use > > vcpu_hvm_context instead of vcpu_guest_context. > > Are you sure? Specifically for ... > > > --- a/xen/include/public/arch-x86/xen.h > > +++ b/xen/include/public/arch-x86/xen.h > > @@ -161,15 +161,6 @@ typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */ > > /* > > * The following is all CPU context. Note that the fpu_ctxt block is filled > > * in by FXSAVE if the CPU has feature FXSR; otherwise FSAVE is used. > > - * > > - * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise > > ... the DOMCTL_setvcpucontext part. Right, I couldn't change DOMCTL_setvcpucontext to use the new struct because it was already in use by gdbsx. So v1 is the right version. Thanks, Roger.
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index f21332e897..ba40b97e97 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -161,15 +161,6 @@ typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */ /* * The following is all CPU context. Note that the fpu_ctxt block is filled * in by FXSAVE if the CPU has feature FXSR; otherwise FSAVE is used. - * - * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise - * for HVM and PVH guests, not all information in this structure is updated: - * - * - For HVM guests, the structures read include: fpu_ctxt (if - * VGCT_I387_VALID is set), flags, user_regs, debugreg[*] - * - * - PVH guests are the same as HVM guests, but additionally use ctrlreg[3] to - * set cr3. All other fields not used should be set to 0. */ struct vcpu_guest_context { /* FPU registers come first so they can be aligned for FXSAVE/FXRSTOR. */
From the vcpu_guest_context structure. PVHv2/HVM uses a completely different structure (vcpu_hvm_context), that's described in hvm_vpcu.h. Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Andrew Cooper <andrew.cooper3@citrix.com> Cc: George Dunlap <George.Dunlap@eu.citrix.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Jan Beulich <jbeulich@suse.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Tim Deegan <tim@xen.org> Cc: Wei Liu <wei.liu2@citrix.com> --- Changes since v1: - Completely remove the comment, HVM guests also use vcpu_hvm_context instead of vcpu_guest_context. --- xen/include/public/arch-x86/xen.h | 9 --------- 1 file changed, 9 deletions(-)