From patchwork Thu Aug 31 15:10:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9932369 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 98BC9602F0 for ; Thu, 31 Aug 2017 15:13:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 778452897B for ; Thu, 31 Aug 2017 15:13:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BD5F28997; Thu, 31 Aug 2017 15:13:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D41D22897B for ; Thu, 31 Aug 2017 15:13:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnR7M-0007bT-Um; Thu, 31 Aug 2017 15:10:52 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnR7L-0007bM-56 for xen-devel@lists.xenproject.org; Thu, 31 Aug 2017 15:10:51 +0000 Received: from [85.158.143.35] by server-9.bemta-6.messagelabs.com id 26/98-03422-AF628A95; Thu, 31 Aug 2017 15:10:50 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeJIrShJLcpLzFFi42JxWrrBXven2op Ig4NfLC2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozWnSvYCtr5KtZfX8rUwNjE08XIySEhECxx 4ug9FhCbTUBH4uLcnWxdjBwcIgIqErf3GnQxcnEwCzxnkng/oYEZpEZYwF/i9p0zYDaLgKrEp f6jrCD1vAKWEhcbPSBG6km8nfiCEcTmFRCUODnzCdh4ZgFNidbtv9khbHmJ5q2zwcYICShK9M 97wDaBkWcWkpZZSFpmIWlZwMi8ilGjOLWoLLVI18hML6koMz2jJDcxM0fX0MBMLze1uDgxPTU nMalYLzk/dxMjMHQYgGAH45kFgYcYJTmYlER5H95eHinEl5SfUpmRWJwRX1Sak1p8iFGGg0NJ gjdAdUWkkGBRanpqRVpmDjCIYdISHDxKIry/VIDSvMUFibnFmekQqVOMilLivPUgfQIgiYzSP Lg2WORcYpSVEuZlBDpEiKcgtSg3swRV/hWjOAejkjBvJcgUnsy8Erjpr4AWMwEtjvVaCrK4JB EhJdXAGOar7NxVoMYqa2L+yHfVdjO/2v3GfOmVshIdnDvbvA94MEzi5O63Oc1jprRk2dKGwvC rRx/lC/HMEuFrdlXcJS561P/guUtzH1ye1ZM5T7Yo88x8jmvX1zRNL+q2EtihKrM+Jz7vcMbC Ff9U1j2QrJj6OeXIZ5Zn5k7Gpyb/fhDr/Hvvgcp7SizFGYmGWsxFxYkA3KpAIJcCAAA= X-Env-Sender: prvs=409eddc5a=roger.pau@citrix.com X-Msg-Ref: server-10.tower-21.messagelabs.com!1504192248!73876868!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 41742 invoked from network); 31 Aug 2017 15:10:49 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-10.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 31 Aug 2017 15:10:49 -0000 X-IronPort-AV: E=Sophos;i="5.41,453,1498521600"; d="scan'208,223";a="446084195" From: Roger Pau Monne To: Date: Thu, 31 Aug 2017 16:10:04 +0100 Message-ID: <20170831151004.93710-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.11.0 (Apple Git-81) MIME-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Jan Beulich , Roger Pau Monne Subject: [Xen-devel] [PATCH v2] x86/pvh: remove stale HVM/PVHv1 comment from public headers X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From the vcpu_guest_context structure. PVHv2/HVM uses a completely different structure (vcpu_hvm_context), that's described in hvm_vpcu.h. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- Changes since v1: - Completely remove the comment, HVM guests also use vcpu_hvm_context instead of vcpu_guest_context. --- xen/include/public/arch-x86/xen.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index f21332e897..ba40b97e97 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -161,15 +161,6 @@ typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */ /* * The following is all CPU context. Note that the fpu_ctxt block is filled * in by FXSAVE if the CPU has feature FXSR; otherwise FSAVE is used. - * - * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise - * for HVM and PVH guests, not all information in this structure is updated: - * - * - For HVM guests, the structures read include: fpu_ctxt (if - * VGCT_I387_VALID is set), flags, user_regs, debugreg[*] - * - * - PVH guests are the same as HVM guests, but additionally use ctrlreg[3] to - * set cr3. All other fields not used should be set to 0. */ struct vcpu_guest_context { /* FPU registers come first so they can be aligned for FXSAVE/FXRSTOR. */