From patchwork Fri Sep 1 09:11:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vitaly Kuznetsov X-Patchwork-Id: 9933789 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 17A5160309 for ; Fri, 1 Sep 2017 09:13:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A956285B7 for ; Fri, 1 Sep 2017 09:13:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3862285E7; Fri, 1 Sep 2017 09:13:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 936EF285B7 for ; Fri, 1 Sep 2017 09:13:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnhzF-0001tu-Uu; Fri, 01 Sep 2017 09:11:37 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnhzE-0001th-9j for xen-devel@lists.xen.org; Fri, 01 Sep 2017 09:11:36 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id B8/99-02044-74429A95; Fri, 01 Sep 2017 09:11:35 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRWlGSWpSXmKPExsVysWW7jK67ysp Ig5VeFks+LmZxYPQ4uvs3UwBjFGtmXlJ+RQJrxufZB9gKrrJVnJi+mLmB8QBrFyMXh5DAbCaJ mbsfAzkcHCwC9hKLbpl0MXJyMAqUSRxZM58Nws6VOHNuHxNE/XxGiY8zO1lAEmwCOhLfn55iB rFFBKQlrn2+zAhSxCzwikli8Y8NbCBDhQUcJOa0OoDUsAioSvxd2MAEEuYVsJDo7jUEMSUEtC XeT84D6ZQQ6GOUuP3jKNMERt4FjAyrGNWLU4vKUot0LfWSijLTM0pyEzNzdA0NjPVyU4uLE9N TcxKTivWS83M3MQIDoZ6BgXEH4+ufTocYJTmYlER5q/1XRArxJeWnVGYkFmfEF5XmpBYfYpTh 4FCS4L2htDJSSLAoNT21Ii0zBxiSMGkJDh4lEd65IGne4oLE3OLMdIjUKUZdjqYPW74wCbHk5 eelSonzTgIpEgApyijNgxsBi49LjLJSwryMDAwMQjwFqUW5mSWo8q8YxTkYlYR534NM4cnMK4 Hb9AroCCagI/59XgFyREkiQkqqgVH7w62cKVUqeyT/SOzZcvNi5Y/bDHGSDx0cd6+dEyPKnV5 33XTZl+1PfpfN/KZZusN4Yq6vZU8651/Nk5plwk98PwhaWGQ0ei5y7b7HzLM2p0hQ5bmxTUjQ AtnHMo2L3ynIOpzWlyn03G5y6q+zu1my4uoVrNOWO+9+ECLy61ttRty6lYHXHiqxFGckGmoxF xUnAgAxzsOLigIAAA== X-Env-Sender: vkuznets@redhat.com X-Msg-Ref: server-15.tower-31.messagelabs.com!1504257093!108590695!1 X-Originating-IP: [209.132.183.28] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMjA5LjEzMi4xODMuMjggPT4gNTQwNjQ=\n X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 61282 invoked from network); 1 Sep 2017 09:11:34 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by server-15.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 1 Sep 2017 09:11:34 -0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C4E5B356CE; Fri, 1 Sep 2017 09:11:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C4E5B356CE Received: from vitty.brq.redhat.com (unknown [10.43.2.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 719CD60BEB; Fri, 1 Sep 2017 09:11:30 +0000 (UTC) From: Vitaly Kuznetsov To: xen-devel@lists.xen.org Date: Fri, 1 Sep 2017 11:11:28 +0200 Message-Id: <20170901091128.21945-1-vkuznets@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 01 Sep 2017 09:11:33 +0000 (UTC) Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Paul Durrant , Jan Beulich Subject: [Xen-devel] [PATCH] xen: reset creation_finished flag on soft reset X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP C/s e7dabe5 ("x86/hvm: don't unconditionally create a default ioreq server") broke soft reset when QEMU traditional is being used. During soft reset QEMU is relaunched and default ioreq server needs to be re-created upon first HVM_PARAM_*IOREQ_* request. The flag will be set back to 'true' when toolstack unpauses the domain, just like after normal creation. Signed-off-by: Vitaly Kuznetsov --- xen/common/domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/domain.c b/xen/common/domain.c index b22aacc57e..b529c5d7ad 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1085,6 +1085,8 @@ int domain_soft_reset(struct domain *d) unmap_vcpu_info(v); } + d->creation_finished = false; + rc = arch_domain_soft_reset(d); if ( !rc ) domain_resume(d);