| Message ID | 20170925105206.66507-23-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Roger Pau Monne writes ("[PATCH v3 22/22] libxl: remove device model "none" from IDL"):
> And the xl.cfg man page documentation.
See my comments about the start of the abolition of "none" as devicd
model. I have acked the intermediate patches.
Feel free to put the explanation for the unceremonious dropping of
this support in whatever commit messages(s) seem appropriate.
(It is interesting to note how much easier this all is because "none"
was never properly supported. If it had been, then we would need much
more careful sequencing of all this work, and also backward
compatibility.)
Thanks,
Ian.
diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index 4e0befcc5b..5d3a9084e6 100644 --- a/docs/man/xl.cfg.pod.5.in +++ b/docs/man/xl.cfg.pod.5.in @@ -2321,11 +2321,6 @@ This device-model is the default for Linux dom0. Use the device-model based upon the historical Xen fork of QEMU. This device-model is still the default for NetBSD dom0. -=item B<none> - -Don't use any device model. This requires a kernel capable of booting -without emulated devices. - =back It is recommended to accept the default value for new guests. If diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index d566535539..1edb805893 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -1001,14 +1001,6 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, const libxl_mac *src); #define LIBXL_HAVE_GFX_PASSTHRU_KIND /* - * LIBXL_HAVE_DEVICE_MODEL_VERSION_NONE - * - * In the case that LIBXL_HAVE_DEVICE_MODEL_VERSION_NONE is set libxl - * allows the creation of HVM guests without a device model. - */ -#define LIBXL_HAVE_DEVICE_MODEL_VERSION_NONE 1 - -/* * LIBXL_HAVE_CHECKPOINTED_STREAM * * If this is defined, then libxl_checkpointed_stream exists. diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 8ae534709a..37922a10cd 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -99,7 +99,6 @@ libxl_device_model_version = Enumeration("device_model_version", [ (0, "UNKNOWN"), (1, "QEMU_XEN_TRADITIONAL"), # Historical qemu-xen device model (qemu-dm) (2, "QEMU_XEN"), # Upstream based qemu-xen device model - (3, "NONE"), # No device model ]) libxl_console_type = Enumeration("console_type", [
And the xl.cfg man page documentation. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> --- docs/man/xl.cfg.pod.5.in | 5 ----- tools/libxl/libxl.h | 8 -------- tools/libxl/libxl_types.idl | 1 - 3 files changed, 14 deletions(-)