diff mbox

[1/2] xen/credit2: add missing unlock

Message ID 20170927114622.14789-2-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu Sept. 27, 2017, 11:46 a.m. UTC 
Coverity-ID: 1418531

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>
---
 xen/common/sched_credit2.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dario Faggioli Sept. 27, 2017, 12:10 p.m. UTC | #1 
On Wed, 2017-09-27 at 12:46 +0100, Wei Liu wrote:
> Coverity-ID: 1418531
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index d33c881c3d..18f39cafe4 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -2831,6 +2831,7 @@ csched2_dom_cntl(
>              if ( op->u.credit2.cap > 100 * sdom->nr_vcpus )
>              {
>                  rc = -EINVAL;
> +                write_unlock_irqrestore(&prv->lock, flags);
>
Indeed... :-/

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario
diff mbox

Patch

diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index d33c881c3d..18f39cafe4 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -2831,6 +2831,7 @@  csched2_dom_cntl(
             if ( op->u.credit2.cap > 100 * sdom->nr_vcpus )
             {
                 rc = -EINVAL;
+                write_unlock_irqrestore(&prv->lock, flags);
                 break;
             }