diff mbox

[for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value

Message ID 20171011154157.8574-1-ross.lagerwall@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ross Lagerwall Oct. 11, 2017, 3:41 p.m. UTC 
Return 0 to indicate success rather than whatever rc was previously set
to (-EINVAL).

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
 xen/arch/x86/hvm/dm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Cooper Oct. 11, 2017, 3:45 p.m. UTC | #1 
On 11/10/17 16:41, Ross Lagerwall wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> ---
>  xen/arch/x86/hvm/dm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> index 82addea..32ade95 100644
> --- a/xen/arch/x86/hvm/dm.c
> +++ b/xen/arch/x86/hvm/dm.c
> @@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
>              &op.u.remote_shutdown;
>  
>          domain_shutdown(d, data->reason);
> +        rc = 0;

Ideally with a newline here (can be fixed on commit).

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Jan Beulich Oct. 11, 2017, 3:48 p.m. UTC | #2 
>>> On 11.10.17 at 17:41, <ross.lagerwall@citrix.com> wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
Wei Liu Oct. 11, 2017, 3:52 p.m. UTC | #3 
On Wed, Oct 11, 2017 at 04:41:57PM +0100, Ross Lagerwall wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Ian Jackson Oct. 11, 2017, 3:53 p.m. UTC | #4 
Andrew Cooper writes ("Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value"):
> On 11/10/17 16:41, Ross Lagerwall wrote:
> > Return 0 to indicate success rather than whatever rc was previously set
> > to (-EINVAL).
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> > ---
> >  xen/arch/x86/hvm/dm.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> > index 82addea..32ade95 100644
> > --- a/xen/arch/x86/hvm/dm.c
> > +++ b/xen/arch/x86/hvm/dm.c
> > @@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
> >              &op.u.remote_shutdown;
> >  
> >          domain_shutdown(d, data->reason);
> > +        rc = 0;
> 
> Ideally with a newline here (can be fixed on commit).

Thanks to Ross for spotting this, and to whoever committed it so
speedily.

Ian.
diff mbox

Patch

diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
index 82addea..32ade95 100644
--- a/xen/arch/x86/hvm/dm.c
+++ b/xen/arch/x86/hvm/dm.c
@@ -636,6 +636,7 @@  static int dm_op(const struct dmop_args *op_args)
             &op.u.remote_shutdown;
 
         domain_shutdown(d, data->reason);
+        rc = 0;
         break;
     }