From patchwork Tue Oct 17 11:36:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Roger Pau Monne X-Patchwork-Id: 10011757 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2BAD3601E7 for ; Tue, 17 Oct 2017 11:39:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BCD6287B9 for ; Tue, 17 Oct 2017 11:39:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0EAF028864; Tue, 17 Oct 2017 11:39:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56682287B9 for ; Tue, 17 Oct 2017 11:39:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4QBA-00068z-FZ; Tue, 17 Oct 2017 11:37:00 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4QB9-00068o-3N for xen-devel@lists.xenproject.org; Tue, 17 Oct 2017 11:36:59 +0000 Received: from [85.158.143.35] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-2.bemta-6.messagelabs.com id D6/E6-30254-A5BE5E95; Tue, 17 Oct 2017 11:36:58 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRWlGSWpSXmKPExsXitHRDpG7k66e RBp/naVp83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBlbzh9mK7jJUzH1wSfmBsbfXF2MnBwSAv4S rfN2sYHYbAI6Ehfn7gSyOThEBFQkbu816GLk4mAW6GGWWDnhLjNIjbCAi8THme9YQWwWAVWJQ 58vg9m8ApYSH9dcZQTplRDQk/ix3RAkzClgJXGgawY7iC0EVLJ4fwcLRLmgxMmZT8BsZgFNid btv9khbHmJ5q2zmSHqFSX65z1gm8DINwtJyywkLbOQtCxgZF7FqF6cWlSWWqRrppdUlJmeUZK bmJmja2hgppebWlycmJ6ak5hUrJecn7uJERhoDECwg3HeCf9DjJIcTEqivM6GTyKF+JLyUyoz Eosz4otKc1KLDzHKcHAoSfB+evk0UkiwKDU9tSItMwcY8jBpCQ4eJRFetldAad7igsTc4sx0i NQpRl2Ojpt3/zAJseTl56VKifNKgBQJgBRllObBjYDF3yVGWSlhXkago4R4ClKLcjNLUOVfMY pzMCoJ8wqDTOHJzCuB2/QK6AgmoCPWOT0BOaIkESEl1cC4KkKga/6VGewGQsv/WqxRUr3okpK jsGByxRefB18m9eTr1X308cgo9Yiac/Uxz3L+0E5P2cC3R55V/T7yZz7DxclPX392MeJavcrO onapo93xfRXvZTsEPmtsn3eb984kyR0rfO/0c23g0MuQ1mZtVhZiPify18v26cxZ/vN9Zpyd/ V7j6L+PSizFGYmGWsxFxYkAvdbWnboCAAA= X-Env-Sender: prvs=45642263d=roger.pau@citrix.com X-Msg-Ref: server-2.tower-21.messagelabs.com!1508240211!63636235!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 56844 invoked from network); 17 Oct 2017 11:36:57 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 17 Oct 2017 11:36:57 -0000 X-IronPort-AV: E=Sophos;i="5.43,390,1503360000"; d="scan'208";a="446617095" From: Roger Pau Monne To: Date: Tue, 17 Oct 2017 12:36:44 +0100 Message-ID: <20171017113644.31866-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.13.5 (Apple Git-94) In-Reply-To: <20171017113644.31866-1-roger.pau@citrix.com> References: <20171017113644.31866-1-roger.pau@citrix.com> MIME-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich , Roger Pau Monne Subject: [Xen-devel] [PATCH for-4.10 2/2] ubsan: disable unaligned access checks X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Currently there are many offenders of the unaligned access checks, which makes booting with the unaligned check a PVH Dom0 impossible. The main offenders seem to be the ACPI code, the VMX code and specially the intremap code (set_ire_sid). Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu Cc: Julien Grall --- I'm not sure whether we prefer to fix the offenders, or just disable the alignment wholesale. In any case if we decide to disable the check, the patch should have vary low impact, and hence should be committed to 4.10 on the base that it only affects ubsan, which is not enabled by default and not to be used on production systems. --- xen/Rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 2659f8a4d1..1472adf1d6 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -120,7 +120,7 @@ $(filter-out %.init.o $(nogcov-y),$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS += - endif ifeq ($(CONFIG_UBSAN),y) -$(filter-out %.init.o $(noubsan-y),$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS += -fsanitize=undefined +$(filter-out %.init.o $(noubsan-y),$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS += -fsanitize=undefined -fno-sanitize=alignment endif ifeq ($(CONFIG_LTO),y)