From patchwork Tue Oct 17 21:41:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 10012977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EBDD560235 for ; Tue, 17 Oct 2017 21:44:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD44328113 for ; Tue, 17 Oct 2017 21:44:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D1C4C28584; Tue, 17 Oct 2017 21:44:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 481BC28113 for ; Tue, 17 Oct 2017 21:44:19 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4Zcj-0007pp-9p; Tue, 17 Oct 2017 21:42:05 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4Zch-0007pY-9U for xen-devel@lists.xenproject.org; Tue, 17 Oct 2017 21:42:03 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id 4F/82-24473-A2976E95; Tue, 17 Oct 2017 21:42:02 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRWlGSWpSXmKPExsVyMfTGYV3Nyme RBq0PrSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1owbJ4+xFvTyV/w8uJypgbGXq4uRi0NIYCaj xIHOr4wgDovAPGaJBVf3MYE4EgL9rBJHnm8CcjiBnDyJ5tXzGCHsNInHc7ewQNjlEgu//2MHs YUEFCR+TzjEBDF2OZPE1QWv2EASbAIaEk9+zQCzRQSUJO6tmgxWxCwwn1Hi3N0OZpCEsICdRO Pf5WBFLAKqEnO614Ft4BUwk1ixpBeohgNom7zEjs2CIGFOAXOJ5ieTWSEWm0lMuH6VcQKj4AJ GhlWM6sWpRWWpRbqWeklFmekZJbmJmTm6hgbGermpxcWJ6ak5iUnFesn5uZsYgSFXz8DAuIPx 9U+nQ4ySHExKorzOhk8ihfiS8lMqMxKLM+KLSnNSiw8xynBwKEnwXi1/FikkWJSanlqRlpkDD H6YtAQHj5IIr3oFUJq3uCAxtzgzHSJ1itGS48KdS3+YOA7suQUkO27e/cMkxJKXn5cqJc6rBt IgANKQUZoHNw4WoZcYZaWEeRkZGBiEeApSi3IzS1DlXzGKczAqCfP+BLmKJzOvBG7rK6CDmIA OWuf0BOSgkkSElFQDo+HMTazTLY/f2vXhu3XY+6z/CoEmd+NSnGPmTFB9yzxxZhHj6SsPJnx9 efbDnWfvOFwkPjNsY5juc779aWLBj9ftqoJ5h6J+B0x3np1d2/BAs+BTwYSPuWuef2r4FxB6+ 3qM2ESmB3nPOCN5NwXe9zx3bEKy2e3cqpXipz5XHpuiduBta+khu04lluKMREMt5qLiRACpFw wkywIAAA== X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-9.tower-31.messagelabs.com!1508276521!55245024!1 X-Originating-IP: [209.85.216.195] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28812 invoked from network); 17 Oct 2017 21:42:01 -0000 Received: from mail-qt0-f195.google.com (HELO mail-qt0-f195.google.com) (209.85.216.195) by server-9.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 17 Oct 2017 21:42:01 -0000 Received: by mail-qt0-f195.google.com with SMTP id z28so6754326qtz.13 for ; Tue, 17 Oct 2017 14:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MJox5YjTpkXsOZiKdoYJrmUgwErMFM0Y/gIPx+mP21Y=; b=MxOIV6oIrgh957tZ+LyEH2rP0wri+atCGvLD1WZcHX2XC8wnGPo1rouluIDft0Fgjk pgHkvDzM5wB1g4eACaszuR1T6fBWOMp1v80hYAi5+QIdXl9hVZR+XSTsgG+KeWQLa++T AEEHlalXzWdp8gRJ+7w2BgA1PKHJPZaApgM6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MJox5YjTpkXsOZiKdoYJrmUgwErMFM0Y/gIPx+mP21Y=; b=E0xWgwQRejsOrfINf1IyHwCD7WNrUU2ly1bxDju0KGzax4Hjh2/3MeC2iaRj2qMoCi jtzgcOPefK+G8Yw65YS/k/oSbWIZfcP/ZMzJLsEiee0O1sSYpNoWbfmxbXP194/XcXxF htTQx+qHxzN0wNTUwCkjRzKNN3Z0cztn9V2fpCXIQ0qGeoRH5c+PiwlJdaB1xPYb4qad 4CrzJn5EAbsD6VrX8bmUc0tPJShYX3Qp+NCPmpEZzU4m1VsYF5jwQFPPQBPUkDPgh3+Z B9aUV1wWh8Si1JFbX7zUq7kyUJT1ayEPKfQRgZV4VbAN0hqxutKek7hvc7G/hNJ30Kng 6BfQ== X-Gm-Message-State: AMCzsaUVlvzPMb2UevVmTPQtgVJvZXuM0nfyTm+XAgKVGch3Isfi2IqB d+KypQ+/27YHsTM2iU55kYyCZZR/4i8= X-Google-Smtp-Source: ABhQp+T2XzA2GiEudylCKeExzvRNnH5B31RBzEwvSRAPCOEJuaHR76rlW0F6RqiApPaCkvI/Kr3AvA== X-Received: by 10.200.23.36 with SMTP id w33mr253844qtj.50.1508276520600; Tue, 17 Oct 2017 14:42:00 -0700 (PDT) Received: from swanson.localdomain (104-179-196-18.lightspeed.brhmal.sbcglobal.net. [104.179.196.18]) by smtp.gmail.com with ESMTPSA id j40sm6826965qtj.52.2017.10.17.14.41.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Oct 2017 14:42:00 -0700 (PDT) From: Doug Goldstein To: xen-devel@lists.xenproject.org Date: Tue, 17 Oct 2017 16:41:38 -0500 Message-Id: <20171017214138.27663-2-cardoe@cardoe.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20171017214138.27663-1-cardoe@cardoe.com> References: <20171017214138.27663-1-cardoe@cardoe.com> Cc: Andrew Cooper , Daniel Kiper , David Esler , Jan Beulich Subject: [Xen-devel] [PATCH v2 2/2] x86/boot: rename send_chr to print_err X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: David Esler The send_chr function sends an entire C-string and not one character and doesn't necessarily just send it over the serial UART anymore so rename it to print_err so that its closer in name to what it does. Reviewed-by: Doug Goldstein Signed-off-by: David Esler Acked-by: Jan Beulich --- xen/arch/x86/boot/head.S | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 9cc35da558..475c678f2c 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -161,7 +161,7 @@ not_multiboot: */ add $sym_offs(.Lbad_ldr_nbs),%esi # Error message xor %edi,%edi # No VGA text buffer - jmp .Lsend_chr + jmp .Lprint_err .Lmb2_efi_ia_32: /* * Here we are on EFI IA-32 platform. Then reliable vga_text_buffer zap is @@ -169,10 +169,10 @@ not_multiboot: */ add $sym_offs(.Lbad_efi_msg),%esi # Error message xor %edi,%edi # No VGA text buffer - jmp .Lsend_chr + jmp .Lprint_err .Lget_vtb: mov sym_esi(vga_text_buffer),%edi -.Lsend_chr: +.Lprint_err: lodsb test %al,%al # Terminate on '\0' sentinel je .Lhalt @@ -185,11 +185,11 @@ not_multiboot: mov %bl,%al out %al,%dx # Send a character over the serial line test %edi,%edi # Is the VGA text buffer available? - jz .Lsend_chr + jz .Lprint_err stosb # Write a character to the VGA text buffer mov $7,%al stosb # Write an attribute to the VGA text buffer - jmp .Lsend_chr + jmp .Lprint_err .Lhalt: hlt jmp .Lhalt