From patchwork Fri Nov 3 14:21:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 10040347 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E6E13602D8 for ; Fri, 3 Nov 2017 14:24:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D396129667 for ; Fri, 3 Nov 2017 14:24:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7F5E29663; Fri, 3 Nov 2017 14:24:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5814D29663 for ; Fri, 3 Nov 2017 14:24:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAcrK-00073K-4j; Fri, 03 Nov 2017 14:22:10 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAcrI-00073E-1a for xen-devel@lists.xenproject.org; Fri, 03 Nov 2017 14:22:08 +0000 Received: from [193.109.254.147] by server-9.bemta-6.messagelabs.com id 5B/1B-30115-F8B7CF95; Fri, 03 Nov 2017 14:22:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRWlGSWpSXmKPExsXitHRDpG5f9Z9 Ig5/Nthbft0xmcmD0OPzhCksAYxRrZl5SfkUCa0bP2YPMBe1sFWd2XGZvYGxn7WLk4JAQ8Je4 O9m+i5GTg01AR+Li3J1sIGERARWJ23sNQMLMAiEST+fdZwaxhQXcJRZd3g9mswCV3JjSzAZi8 wpYSjRuA5nICTRRT6L500l2iLigxMmZT1gg5mhKtG7/zQ5hy0s0b50NNkdIQFGif94DtgmMPL OQtMxC0jILScsCRuZVjOrFqUVlqUW65npJRZnpGSW5iZk5uoYGZnq5qcXFiempOYlJxXrJ+bm bGIFhwwAEOxhnXvY/xCjJwaQkyruz5E+kEF9SfkplRmJxRnxRaU5q8SFGGQ4OJQnexVVAOcGi 1PTUirTMHGAAw6QlOHiURHjlQNK8xQWJucWZ6RCpU4yWHDceXv/DxNFx8y6QfDbzdQOzEEtef l6qlDgvK0iDAEhDRmke3DhYlF1ilJUS5mUEOlCIpyC1KDezBFX+FaM4B6OSMK80yBSezLwSuK 2vgA5iAjpoNgfYQSWJCCmpBsayTZ0vPjJ8/rlU3OS1XumBhMqrfsr/64NCF1SuXbLU6+LMLPE ErlCFdS4a9d8c94r9PHNsokIOzyRuvp5ay3KGAL6Fmub8Ft1T2RbZ7k8N1clMtdi1nP3W9Mst ihYOyxpZuDLkXiav6WkVOf1aREbf+nld7z+nrJ3Hvoj0nNw23az3ksrtHiWW4oxEQy3mouJEA Pt0FJmtAgAA X-Env-Sender: prvs=4732e1864=roger.pau@citrix.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1509718925!82998234!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25746 invoked from network); 3 Nov 2017 14:22:06 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-11.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 3 Nov 2017 14:22:06 -0000 X-IronPort-AV: E=Sophos;i="5.44,339,1505779200"; d="scan'208";a="449937802" From: Roger Pau Monne To: Date: Fri, 3 Nov 2017 14:21:29 +0000 Message-ID: <20171103142129.82695-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.13.6 (Apple Git-96) MIME-Version: 1.0 Cc: Ian Jackson , Roger Pau Monne Subject: [Xen-devel] [PATCH] osstest: remove unneeded rm in ts-freebsd-host-install X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The usage of `rm` here is wrong for two reasons: - It will fail if $sharedpath.tmp doesn't exist and report and error (ie: -f should be used). - It's not needed because dd will truncate $sharedpath.tmp. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson --- ts-freebsd-host-install | 1 - 1 file changed, 1 deletion(-) diff --git a/ts-freebsd-host-install b/ts-freebsd-host-install index 447a5076..4aff7214 100755 --- a/ts-freebsd-host-install +++ b/ts-freebsd-host-install @@ -96,7 +96,6 @@ targetpath=$4 cd $basedir mkdir -p `dirname $sharedpath` if [ ! -f $sharedpath ]; then - rm $sharedpath.tmp dd if=$imagepath of=$sharedpath.tmp mv $sharedpath.tmp $sharedpath fi