diff mbox

[for-4.10] gcov: return EOPNOTSUPP for unimplemented gcov domctl

Message ID 20171107123150.86033-1-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roger Pau Monne Nov. 7, 2017, 12:31 p.m. UTC 
ENOSYS should only be used by unimplemented top-level syscalls. Use
EOPNOTSUPP instead.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reported-by: Jan Beulich <JBeulich@suse.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Julien Grall <julien.grall@linaro.org>
---
 xen/common/gcov/gcov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich Nov. 7, 2017, 2:20 p.m. UTC | #1 
>>> On 07.11.17 at 13:31, <roger.pau@citrix.com> wrote:
> ENOSYS should only be used by unimplemented top-level syscalls. Use
> EOPNOTSUPP instead.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reported-by: Jan Beulich <JBeulich@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
Julien Grall Nov. 8, 2017, 12:25 p.m. UTC | #2 
Hi,

On 07/11/17 14:20, Jan Beulich wrote:
>>>> On 07.11.17 at 13:31, <roger.pau@citrix.com> wrote:
>> ENOSYS should only be used by unimplemented top-level syscalls. Use
>> EOPNOTSUPP instead.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Reported-by: Jan Beulich <JBeulich@suse.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Release-acked-by: Julien Grall <julien.grall@linaro.org>

Cheers,
Jan Beulich Nov. 8, 2017, 12:44 p.m. UTC | #3 
>>> On 07.11.17 at 13:31, <roger.pau@citrix.com> wrote:
> ENOSYS should only be used by unimplemented top-level syscalls. Use
> EOPNOTSUPP instead.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reported-by: Jan Beulich <JBeulich@suse.com>

Btw I've taken the liberty to make the title say "sysctl" instead of
"domctl".

Jan
diff mbox

Patch

diff --git a/xen/common/gcov/gcov.c b/xen/common/gcov/gcov.c
index 35653fd8d8..283d2eec86 100644
--- a/xen/common/gcov/gcov.c
+++ b/xen/common/gcov/gcov.c
@@ -239,7 +239,7 @@  int sysctl_gcov_op(struct xen_sysctl_gcov_op *op)
         break;
 
     default:
-        ret = -ENOSYS;
+        ret = -EOPNOTSUPP;
         break;
     }