diff mbox series

[v1] install pkgconfig files into libdir

Message ID 20190325160010.24584-1-olaf@aepfle.de (mailing list archive)
State New, archived
Headers show
Series [v1] install pkgconfig files into libdir | expand

Commit Message

Olaf Hering March 25, 2019, 4 p.m. UTC
Most pkgconfig files contain a Libs: variable, which is either /usr/lib
or /usr/lib64. If a 32bit and a 64bit variant of xen libraries is
installed, the last one wins. As a result compiling for the other
bitsize will fail.

Instead of sharedir use libdir as install target. This matches both the
documentation and the expected result.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---

I think this deserves a backport to relesed versions.


 config/Paths.mk.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wei Liu May 13, 2019, 1:53 p.m. UTC | #1
On Mon, Mar 25, 2019 at 05:00:10PM +0100, Olaf Hering wrote:
> Most pkgconfig files contain a Libs: variable, which is either /usr/lib
> or /usr/lib64. If a 32bit and a 64bit variant of xen libraries is
> installed, the last one wins. As a result compiling for the other
> bitsize will fail.
> 
> Instead of sharedir use libdir as install target. This matches both the
> documentation and the expected result.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wei.liu2@citrix.com>
diff mbox series

Patch

diff --git a/config/Paths.mk.in b/config/Paths.mk.in
index 8a518d5a5d..dc9d0c0353 100644
--- a/config/Paths.mk.in
+++ b/config/Paths.mk.in
@@ -58,4 +58,4 @@  XENFIRMWAREDIR           := @XENFIRMWAREDIR@
 XEN_CONFIG_DIR           := @XEN_CONFIG_DIR@
 XEN_SCRIPT_DIR           := @XEN_SCRIPT_DIR@
 
-PKG_INSTALLDIR           := ${SHAREDIR}/pkgconfig
+PKG_INSTALLDIR           := ${libdir}/pkgconfig