| Message ID | 20190327184531.30986-5-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/arm: Add support to build with clang | expand |
On 3/27/19 8:45 PM, Julien Grall wrote: > The commit 8d84e701fd "xen/arm: initialize access" initializes > *access using the wrong enumeration type. This result to a warning > using clang: > > mem_access.c:50:20: error: implicit conversion from enumeration type > 'p2m_access_t' to different enumeration type 'xenmem_access_t' > [-Werror,-Wenum-conversion] > *access = p2m->default_access; > ~ ~~~~~^~~~~~~~~~~~~~ > > The correct solution is to use the array memaccess that will do the > conversion between the 2 enums. > > Fixes: 8d84e701fd ("xen/arm: initialize access") > Signed-off-by: Julien Grall <julien.grall@arm.com> Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c index db49372a2c..3e3620294c 100644 --- a/xen/arch/arm/mem_access.c +++ b/xen/arch/arm/mem_access.c @@ -47,7 +47,7 @@ static int __p2m_get_mem_access(struct domain *d, gfn_t gfn, }; ASSERT(p2m_is_locked(p2m)); - *access = p2m->default_access; + *access = memaccess[p2m->default_access]; /* If no setting was ever set, just return rwx. */ if ( !p2m->mem_access_enabled )
The commit 8d84e701fd "xen/arm: initialize access" initializes *access using the wrong enumeration type. This result to a warning using clang: mem_access.c:50:20: error: implicit conversion from enumeration type 'p2m_access_t' to different enumeration type 'xenmem_access_t' [-Werror,-Wenum-conversion] *access = p2m->default_access; ~ ~~~~~^~~~~~~~~~~~~~ The correct solution is to use the array memaccess that will do the conversion between the 2 enums. Fixes: 8d84e701fd ("xen/arm: initialize access") Signed-off-by: Julien Grall <julien.grall@arm.com> --- This patch is candidate for backporting in 4.12. --- xen/arch/arm/mem_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)