Message ID | 20190619130335.3458-1-olaf@aepfle.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v1] Remove tools/examples/cpupool | expand |
On Wed, 2019-06-19 at 15:03 +0200, Olaf Hering wrote: > In the near future all fresh installations will have an empty /etc. > The content of this directory will not be controlled by the package > manager anymore. One of the reasons for this move is to make > snapshots > more robust. > > Installing empty configuration files is not helpful for an empty /etc > directory. The expected values are all described in xlcpupool.cfg(5). > There is no need to duplicate this info into another file. > The need for a dedicated file is also described in xl(1) cpupool- > create. > Apart from the consideration about the content of /etc, I agree with this last statement. We have all we need in the manpage, and that the usefulness of this example config is quite low. Therefore: > Signed-off-by: Olaf Hering <olaf@aepfle.de> > Acked-by: Dario Faggioli <dfaggioli@suse.com> (And sorry it took me a bit to get to this.) Regards
diff --git a/tools/examples/Makefile b/tools/examples/Makefile index 147ea590ef..64b2330b03 100644 --- a/tools/examples/Makefile +++ b/tools/examples/Makefile @@ -6,7 +6,6 @@ XEN_READMES = README XEN_CONFIGS += xlexample.hvm XEN_CONFIGS += xlexample.pvlinux -XEN_CONFIGS += cpupool XEN_CONFIGS += $(XEN_CONFIGS-y) diff --git a/tools/examples/README b/tools/examples/README index 48ace82189..d134945eb7 100644 --- a/tools/examples/README +++ b/tools/examples/README @@ -13,7 +13,6 @@ block - called by xen-backend.agent to bind/unbind dev block-common.sh - sourced by block, block-* block-enbd - binds/unbinds network block devices block-nbd - binds/unbinds network block devices -cpupool - example configuration script for 'xl cpupool-create' external-device-migrate - called by xend for migrating external devices locking.sh - locking functions to prevent concurrent access to critical sections inside script files diff --git a/tools/examples/cpupool b/tools/examples/cpupool deleted file mode 100644 index 35e229e462..0000000000 --- a/tools/examples/cpupool +++ /dev/null @@ -1,17 +0,0 @@ -#============================================================================ -# Configuration setup for 'xm cpupool-create' or 'xl cpupool-create'. -# This script sets the parameters used when a cpupool is created using -# 'xm cpupool-create' or 'xl cpupool-create'. -# You use a separate script for each cpupool you want to create, or -# you can set the parameters for the cpupool on the xm command line. -#============================================================================ - -# the name of the new cpupool -name = "Example-Cpupool" - -# the scheduler to use: valid are e.g. credit, credit2 and rtds -sched = "credit" - -# list of cpus to use -cpus = ["2", "3"] -
In the near future all fresh installations will have an empty /etc. The content of this directory will not be controlled by the package manager anymore. One of the reasons for this move is to make snapshots more robust. Installing empty configuration files is not helpful for an empty /etc directory. The expected values are all described in xlcpupool.cfg(5). There is no need to duplicate this info into another file. The need for a dedicated file is also described in xl(1) cpupool-create. Signed-off-by: Olaf Hering <olaf@aepfle.de> --- tools/examples/Makefile | 1 - tools/examples/README | 1 - tools/examples/cpupool | 17 ----------------- 3 files changed, 19 deletions(-) delete mode 100644 tools/examples/cpupool