From patchwork Tue Jul 23 15:48:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 11054709 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EE7F613A0 for ; Tue, 23 Jul 2019 15:50:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF000286A2 for ; Tue, 23 Jul 2019 15:50:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D326328524; Tue, 23 Jul 2019 15:50:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8713928524 for ; Tue, 23 Jul 2019 15:50:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hpx2A-0007Fz-MB; Tue, 23 Jul 2019 15:48:58 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hpx29-0007Fk-77 for xen-devel@lists.xenproject.org; Tue, 23 Jul 2019 15:48:57 +0000 X-Inumbo-ID: 60c23d50-ad61-11e9-8980-bc764e045a96 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 60c23d50-ad61-11e9-8980-bc764e045a96; Tue, 23 Jul 2019 15:48:56 +0000 (UTC) Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 5c1fSqWdcYmxRezgLVYWOVoPayknzFTuBy+R2TB0SqNR4YfoDgIycVdP8XVoETTAf4ri9aJhZy vjiv9hUCYRiHncLx+gcCniRU4VFODMkSd1FJwsjG+di/vBs75GAmfetfFaG1rXQN/Lapks/scM nt7AYIM9h+uoYZYhJJx45IfMZHYxcTOWJWgyHwyg3GtTBZdFavFTXE3IoEL91MFH/8SFDLmc8S G9yEpEbTd/WUxIxRUk2C6qdCeipEMpO3ITdLbE9+j7hEUKmmewQJy1AQzhxgp9ZL5Rnqj6m5jG uh0= X-SBRS: 2.7 X-MesageID: 3321387 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,299,1559534400"; d="scan'208";a="3321387" From: Roger Pau Monne To: Date: Tue, 23 Jul 2019 17:48:50 +0200 Message-ID: <20190723154851.77627-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.20.1 (Apple Git-117) In-Reply-To: <20190723154851.77627-1-roger.pau@citrix.com> References: <20190723154851.77627-1-roger.pau@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/2] x86/iommu: avoid mapping the interrupt address range for hwdom X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Jan Beulich , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Current code only prevent mapping the lapic page into the guest physical memory map. Expand the range to be 0xFEEx_xxxx as described in the Intel VTd specification section 3.13 "Handling Requests to Interrupt Address Range". AMD also lists this address range in the AMD SR5690 Databook, section 2.4.4 "MSI Interrupt Handling and MSI to HT Interrupt Conversion". Requested-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/drivers/passthrough/x86/iommu.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index 0fa6dcc3fd..88a87cf7a4 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -226,19 +226,9 @@ static bool __hwdom_init hwdom_iommu_map(const struct domain *d, return false; } - /* - * Check that it doesn't overlap with the LAPIC - * TODO: if the guest relocates the MMIO area of the LAPIC Xen should make - * sure there's nothing in the new address that would prevent trapping. - */ - if ( has_vlapic(d) ) - { - const struct vcpu *v; - - for_each_vcpu(d, v) - if ( pfn == PFN_DOWN(vlapic_base_address(vcpu_vlapic(v))) ) - return false; - } + /* Check that it doesn't overlap with the Interrupt Address Range. */ + if ( pfn >= 0xfee00 && pfn <= 0xfeeff ) + return false; /* ... or the IO-APIC */ for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )