From patchwork Fri Jul 26 16:27:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Chen" X-Patchwork-Id: 11061385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 787BA13A4 for ; Fri, 26 Jul 2019 16:34:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6847228B4B for ; Fri, 26 Jul 2019 16:34:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C9C728B50; Fri, 26 Jul 2019 16:34:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=2.0 tests=BAYES_00,FROM_ADDR_WS, FROM_WSP_TRAIL,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=no version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 37CAB28B51 for ; Fri, 26 Jul 2019 16:34:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hr399-0007dR-7O; Fri, 26 Jul 2019 16:32:43 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hr397-0007dL-Lq for xen-devel@lists.xenproject.org; Fri, 26 Jul 2019 16:32:41 +0000 X-Inumbo-ID: fbcccc48-afc2-11e9-8980-bc764e045a96 Received: from mga03.intel.com (unknown [134.134.136.65]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id fbcccc48-afc2-11e9-8980-bc764e045a96; Fri, 26 Jul 2019 16:32:39 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 09:32:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="198421323" Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2019 09:32:37 -0700 From: Zhang Chen To: Ian Jackson , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Date: Sat, 27 Jul 2019 00:27:23 +0800 Message-Id: <20190726162723.7443-1-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.GIT Subject: [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Zhang Chen MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Zhang Chen Xen COLO and KVM COLO shared lots of code in Qemu. The colo-compare object in Qemu now requires an 'iothread' property since QEMU 2.11. Detail: https://wiki.qemu.org/Features/COLO Signed-off-by: Zhang Chen Reviewed-by: Anthony PERARD --- tools/libxl/libxl_dm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index f4fc96415d..839c5ac2cd 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -1634,8 +1634,10 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, nics[i].colo_compare_out && nics[i].colo_compare_notify_dev) { flexarray_append(dm_args, "-object"); + flexarray_append(dm_args, "iothread,id=colo-compare-iothread-1"); + flexarray_append(dm_args, "-object"); flexarray_append(dm_args, - GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s", + GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s,iothread=colo-compare-iothread-1", nics[i].colo_compare_pri_in, nics[i].colo_compare_sec_in, nics[i].colo_compare_out,