Message ID | 20190910140818.9184-1-andrew.cooper3@citrix.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | tools/ocaml: Fix build error with CentOS 7 | expand |
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index f86ecc7b7e..d7bc2cf40d 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -160,7 +160,7 @@ static unsigned int ocaml_list_to_c_bitmap(value l) * for xenctrl_abi_check. The parsing there is ad-hoc. */ { - unsigned int val; + unsigned int val = 0; for ( ; l != Val_none; l = Field(l, 1) ) val |= 1u << Int_val(Field(l, 0));
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) complains: xenctrl_stubs.c: In function 'stub_xc_domain_create': xenctrl_stubs.c:216:28: error: 'val' may be used uninitialized in this function [-Werror=maybe-uninitialized] cfg.arch.emulation_flags = ocaml_list_to_c_bitmap ^ xenctrl_stubs.c:198:12: error: 'val' may be used uninitialized in this function [-Werror=maybe-uninitialized] cfg.flags = ocaml_list_to_c_bitmap ^ cc1: all warnings being treated as errors GCC doesn't point at the correct piece of code, but the diagnostic text is correct, and can occur when the list is empty. Initialise val to 0. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Ian Jackson <Ian.Jackson@citrix.com> CC: Wei Liu <wl@xen.org> CC: Christian Lindig <christian.lindig@citrix.com> --- tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)