From patchwork Fri Sep 13 16:20:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11144991 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0D4D14DB for ; Fri, 13 Sep 2019 16:21:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C8B320830 for ; Fri, 13 Sep 2019 16:21:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="GnAGDjYe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C8B320830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i8oJA-0007eb-Hu; Fri, 13 Sep 2019 16:20:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i8oJ8-0007eU-R3 for xen-devel@lists.xenproject.org; Fri, 13 Sep 2019 16:20:26 +0000 X-Inumbo-ID: 6447bfea-d642-11e9-95af-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6447bfea-d642-11e9-95af-12813bfff9fa; Fri, 13 Sep 2019 16:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568391626; h=from:to:cc:subject:date:message-id:mime-version; bh=Vs8jextvbTqcQh/NkdQfvsElfYfr2aJSQ2QtGTtzVxw=; b=GnAGDjYecrN7+/APe8SKTGcIQHnzpkM9SQi5stp9aUKcEyPGKATEfIYX RWc+ZPYPXSUySeZMZxkMRI5Z2/0SCJUIDrpilKulV2do2nHjmXaIYDOyL NzF66IatvaicXa1gfnA7NkUO6NNX4sisWkhbZMbt+ywBuucjXPPLgoXCD s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 48UjLFRDoUjys98vfXB3bxqkqL8QcSLRlJdxfwL8/Qba2ZvvykvHu7JzsDuOFblJKmQNP6lBoG KgomZ93jcXhufW5W9G+hONNp17rEbHEteGbPZCmb6LM5L1TfZ3j3NJrB0J5o0GsONSI5hBegEz fpS43jUOlFGYsSrfzGwgSddWyoqLn6eNa5UqVdCMaUKUrk5sAPzGT4VjTeST3xnXSEbS4SrPK0 6MCQMILMc53rA0WlSOis3zZXOON9bBo9eUCLuoUDY1dUYIbvg6JktNJQSq2TCDab8HHQdCiAU0 wos= X-SBRS: 2.7 X-MesageID: 5547347 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,501,1559534400"; d="scan'208";a="5547347" From: Andrew Cooper To: Xen-devel Date: Fri, 13 Sep 2019 17:20:21 +0100 Message-ID: <20190913162021.23329-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] drivers/acpi: Drop "ERST table was not found" message X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" ERST isn't a mandatory table, and also isn't very common to find. The message is unnecessary noise during boot. Furthermore, it is redundant with the list of found ACPI tables printed just ahead. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich --- xen/drivers/acpi/apei/erst.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c index 23a4e822e7..c5df512b98 100644 --- a/xen/drivers/acpi/apei/erst.c +++ b/xen/drivers/acpi/apei/erst.c @@ -791,10 +791,9 @@ int __init erst_init(void) return -ENODEV; status = acpi_get_table_phys(ACPI_SIG_ERST, 0, &erst_addr, &erst_len); - if (status == AE_NOT_FOUND) { - printk(KERN_INFO "ERST table was not found\n"); + if (status == AE_NOT_FOUND) return -ENODEV; - } + if (ACPI_FAILURE(status)) { const char *msg = acpi_format_exception(status); printk(KERN_WARNING "Failed to get ERST table: %s\n", msg);