From patchwork Thu Sep 19 10:03:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 11152077 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 114C514ED for ; Thu, 19 Sep 2019 10:06:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E114E2196E for ; Thu, 19 Sep 2019 10:06:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="DEnlGeeo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E114E2196E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAtIC-0007sq-9u; Thu, 19 Sep 2019 10:04:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAtIA-0007sM-AE for xen-devel@lists.xenproject.org; Thu, 19 Sep 2019 10:04:02 +0000 X-Inumbo-ID: cd3a002c-dac4-11e9-9652-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cd3a002c-dac4-11e9-9652-12813bfff9fa; Thu, 19 Sep 2019 10:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568887440; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RFaNCsSNiuwizURXDMM7ff2qNezNkr/OhwAzlqhjsGA=; b=DEnlGeeo8Ywk6jR01WiDpjC0ot9LZXjJec4/Xcj2MI1Cw756QQbKm5Oc 0f6mFlredh4wIrOEvkVLPLr41w1t9nxfqWfMj/1qEuDklpBVjZLYcQSt0 fkFomorfgSgi1vusp66MIx8mrBrSvGfuyHLCw3vKEpOO1FG/7OoPEY/Vy s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: /s5GsSB1xbFaIAj8OAme0DSyTEHEpYdimBiKkUbtN4J41B0S4/rXbL22m2B2JIiL98B/E+i/I7 bNtJ8eBnqJuCEiZO1PWNe5aPB5Y8TYknSluNoiDuetv0kz5wM9wh2RJZxcT7rJPxXz8bqbwk0f heRjTWW6LuGzJg19HZKwoWtnA+GLuQUEphEiiaxMeLr9HSTxvghb4Bf4PUPSSJrL+pjYCqcVMo y/zSsbqVob1ERpxkfOvQkrO8TeCOPZySoXCTCyAnsGI3uJbCgGCdttuPrOywqhE4IDxBgXKx6i 4B4= X-SBRS: 2.7 X-MesageID: 5981864 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,523,1559534400"; d="scan'208";a="5981864" From: Anthony PERARD To: Date: Thu, 19 Sep 2019 11:03:34 +0100 Message-ID: <20190919100334.790782-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <23938.2413.911345.500080@mariner.uk.xensource.com> References: <23938.2413.911345.500080@mariner.uk.xensource.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2 11/15] libxl_usb: Fix wrong usage of asserts X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Replace the assert(0) by abort() since the intention in libxl is that asserts are always compiled in. This patch makes its clear and removes the need to deal with asserts been compiled out. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v2: - replace asserts by abort(). tools/libxl/libxl_usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c index 3d389c019822..9f72857d87af 100644 --- a/tools/libxl/libxl_usb.c +++ b/tools/libxl/libxl_usb.c @@ -147,8 +147,7 @@ static int libxl__device_from_usbctrl(libxl__gc *gc, uint32_t domid, device->backend_kind = LIBXL__DEVICE_KIND_NONE; break; default: - assert(0); /* can't really happen. */ - break; + abort(); /* can't really happen. */ } device->devid = usbctrl->devid; device->domid = domid; @@ -370,8 +369,7 @@ static int libxl__device_usbctrl_add_hvm(libxl__gc *gc, uint32_t domid, flexarray_append_pair(qmp_args, "p3", GCSPRINTF("%d", usbctrl->ports)); break; default: - assert(0); /* Should not be possible. */ - break; + abort(); /* Should not be possible. */ } flexarray_append_pair(qmp_args, "id",