From patchwork Thu Oct 3 09:50:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11172399 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4771214DB for ; Thu, 3 Oct 2019 09:51:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21B6F217D7 for ; Thu, 3 Oct 2019 09:51:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="XCXk5oYV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21B6F217D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eu.citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iFxkR-00020j-BW; Thu, 03 Oct 2019 09:50:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iFxkP-00020e-By for xen-devel@lists.xenproject.org; Thu, 03 Oct 2019 09:50:09 +0000 X-Inumbo-ID: 2f01ed7a-e5c3-11e9-9722-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by localhost (Halon) with ESMTPS id 2f01ed7a-e5c3-11e9-9722-12813bfff9fa; Thu, 03 Oct 2019 09:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1570096209; h=from:to:cc:subject:date:message-id:mime-version; bh=la3EOeGeEDaDt6xOOJ0qHNSFn96WBAVqTy8mtNzswBY=; b=XCXk5oYVoCwnCFBA/90xOOAtX7gS72crJ0TlK3uWD4vbCHLj0XEEpcjH ht9X0RrrcnJVECZ2meluLHVEvVLW+TcFiTCdvJ91OzjL/tEGJA+co6pwz COZwEmLav8CVq2ZZkqJi+tr8ZabS3oLc7RDDSQKwnVyvjypIkK2vF3e1u E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: dtlaAVr9p2Kkl2PojTWNPFUY3zRdiZQLH+1J7ui7ddFjQuiXWGgieo9ni8SUuEkuwBOpIyBBHc PpJ/3nCTkzaTqJNTltj6or3NZx6iUkv7uSzds/vs4N5MtFBj0A/QkRth8Z6OJbuXUaNaGtWjYR bMaRgbyU6DUMKrF4jb74zvx7w5Z7ZvYwtkdBiEwQ/+ywgl6EdpErgFxa4kE2839hT4F1eoq9qD kUF9VW8jHHm146ymxwW5+F8mcRJ1K5aRXDAW0iiaUjbldc6czxRF6nQFpLVQOG4uW1p2J97muG kjM= X-SBRS: 2.7 X-MesageID: 6412317 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.67,251,1566878400"; d="scan'208";a="6412317" From: Ian Jackson To: Date: Thu, 3 Oct 2019 10:50:04 +0100 Message-ID: <20191003095004.30676-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH] Osstest.pm: Fix main_revision_job_cond after 0964bab7a9ea X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In other_revision_job_suffix: Take and pass referring runvar name we updated main_revision_job_cond to pass a dummy 'x' for the new parameter. But the parameter is a sql expression, not a value, and so an extra pair of quotes are needed. This error broke sg-check-tested and this fix fixes it. Signed-off-by: Ian Jackson --- Osstest.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest.pm b/Osstest.pm index c14531e3..d6c1b709 100644 --- a/Osstest.pm +++ b/Osstest.pm @@ -388,7 +388,7 @@ END sub main_revision_job_cond ($) { my ($jobfield) = @_; - return "(${\ other_revision_job_suffix($jobfield,'x','x') } = '')"; + return "(${\ other_revision_job_suffix($jobfield,\"'x'\",'x') } = '')"; } sub get_harness_rev () {