diff mbox series

[XEN,for-4.13,v7,01/11] libxl: Offer API versions 0x040700 and 0x040800

Message ID 20191023130013.32382-2-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show
Series libxl memkb & pt defaulting | expand

Commit Message

Ian Jackson Oct. 23, 2019, 1 p.m. UTC 
According to git log -G:

0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481)
  "tools/libxl: rename remus device to checkpoint device"

0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437)
  "libxl: memory size in kb requires 64 bit variable"

It is surprising that no-one noticed this.

Anyway, in the meantime, we should fix it.  Backporting this is
probably a good idea: it won't change the behaviour for existing
callers but it will avoid errors for some older correct uses.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
---
v2: Adjusted commit message slightly.
---
 tools/libxl/libxl.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Jürgen Groß Oct. 23, 2019, 1:39 p.m. UTC | #1 
On 23.10.19 15:00, Ian Jackson wrote:
> According to git log -G:
> 
> 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481)
>    "tools/libxl: rename remus device to checkpoint device"
> 
> 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437)
>    "libxl: memory size in kb requires 64 bit variable"
> 
> It is surprising that no-one noticed this.
> 
> Anyway, in the meantime, we should fix it.  Backporting this is
> probably a good idea: it won't change the behaviour for existing
> callers but it will avoid errors for some older correct uses.
> 
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen
Olaf Hering Oct. 26, 2020, 4:42 p.m. UTC | #2 
On Wed, Oct 23, Ian Jackson wrote:

> 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481)
> 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437)

> Anyway, in the meantime, we should fix it.  Backporting this is
> probably a good idea: it won't change the behaviour for existing
> callers but it will avoid errors for some older correct uses.

> +    LIBXL_API_VERSION != 0x040700 && LIBXL_API_VERSION != 0x040800 && \


Why was this never backported to staging-4.12 and older?
Please backport it to assist libvirt.

Olaf
Jan Beulich Oct. 26, 2020, 4:48 p.m. UTC | #3 
On 26.10.2020 17:42, Olaf Hering wrote:
> On Wed, Oct 23, Ian Jackson wrote:
> 
>> 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481)
>> 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437)
> 
>> Anyway, in the meantime, we should fix it.  Backporting this is
>> probably a good idea: it won't change the behaviour for existing
>> callers but it will avoid errors for some older correct uses.
> 
>> +    LIBXL_API_VERSION != 0x040700 && LIBXL_API_VERSION != 0x040800 && \
> 
> 
> Why was this never backported to staging-4.12 and older?
> Please backport it to assist libvirt.

I'm afraid the request comes too late for 4.12 (branch now
closed for its final stable release to be cut) and older
(already in security-only mode).

Jan
diff mbox series

Patch

diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index 2555e9cd3b..518fc9e47f 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -655,6 +655,7 @@  typedef struct libxl__ctx libxl_ctx;
 #ifdef LIBXL_API_VERSION
 #if LIBXL_API_VERSION != 0x040200 && LIBXL_API_VERSION != 0x040300 && \
     LIBXL_API_VERSION != 0x040400 && LIBXL_API_VERSION != 0x040500 && \
+    LIBXL_API_VERSION != 0x040700 && LIBXL_API_VERSION != 0x040800 && \
     LIBXL_API_VERSION != 0x041300
 #error Unknown LIBXL_API_VERSION
 #endif