From patchwork Mon Nov 4 16:57:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11226093 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C4A3413A4 for ; Mon, 4 Nov 2019 16:59:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A04A52080F for ; Mon, 4 Nov 2019 16:59:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="IOWCybr+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A04A52080F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eu.citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iRffq-00073g-JJ; Mon, 04 Nov 2019 16:57:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iRffp-00073X-Cu for xen-devel@lists.xenproject.org; Mon, 04 Nov 2019 16:57:49 +0000 X-Inumbo-ID: 36679be4-ff24-11e9-a184-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 36679be4-ff24-11e9-a184-12813bfff9fa; Mon, 04 Nov 2019 16:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1572886661; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RLldk9pTBhTIM8pPpe2SSdifI4wMITzVvbKeaTeNihg=; b=IOWCybr+NhDXMwI5sPwWu0S8DAwXgzqlIGCcz9c81rdCbb0/DjNGp9uk HlDHKNF82FI+svIQpUETDf7qBYUgMYR5FLZO1ONw3mxy9pIahuN5f19M9 4bvy7SJQY5nJBFibkSjQ/h8CKVYeWj3Gr2hj5IHF+LcP24pHWGDJZEzEX o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Lf8iaAuY1aFdr0XQBfTSFHLV42icerAsVpQCmUpd2G9xDO8q8A1QiOX3ZfaHPxjXR5cv9vx77a dvWy+xXnCQaWcv6CaLQxnwg2Hp0RfKOhM1CK/5yLQC60E+Z3vOTZDyEh2Jdf4hoVWQTxv+j2x5 sdvtj7ohqujxqtX8j0aPXLxp66rRW/Zr6HR8189VPrH/QWcRhpYeh4IbXAQcw7adaSjaw6plNP RRbQL6aBSXTKsyCXBE3z7Zz4CN9FLIDxgE42KW6gM/d1UxLEOW7WsBjD+DL5PrK/ErdeV/9Y7q tNY= X-SBRS: 2.7 X-MesageID: 8157969 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,267,1569297600"; d="scan'208";a="8157969" From: Ian Jackson To: Date: Mon, 4 Nov 2019 16:57:35 +0000 Message-ID: <20191104165735.7335-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH] adhoc-revtuple-generator: Bisect over 5000 commits (really) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= , =?utf-8?q?Roger_Pau_?= =?utf-8?q?Monn=C3=A9?= , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In e9b0653875b3 we changed one of the `1000' values to `5000'. But this magic number had been duplicated. Urgh! The result is that adhoc-revtuple-generator might generate a weirdly truncated output which causes cs-bisection-stop to fail with messages like this: *** not RelvUp at 3d40147282670d597b336be5599b5cc4c2ff7ddd at ./cs-bisection-step line 554. *** not RelvDown at 2fa3479cfadb0bb3fe694dbfd29f2350eb2570df at ./cs-bisection-step line 554. *** not RelvUp at 2fa3479cfadb0bb3fe694dbfd29f2350eb2570df at ./cs-bisection-step line 554. ... Use of uninitialized value in concatenation (.) or string at ./cs-bisection-step line 747. Should test . BROKEN see earlier errors. at ./cs-bisection-step line 1454, line 10089. Fix this by (i) plumbing the magic value we already edited properly back to the (command-line controlled) global variable (ii) changing the global variable from 1000 to 5000. git-grep '\b1000\b' still produces a fair amount of output but most of it is timeouts, which is fair enough. There is also a flight count limit in sg-report-flight, which limits how far back it is willing to look. We don't want to change that here. With this change, cs-bisection-step on the currently-failing freebsd build job does this: Searching for interesting versions Result found: flight 141420 (pass), for basis pass Result found: flight 143397 (fail), for basis failure Need to reproduce basis pass (pass); had 1 already. Should test 2fa3479cfadb0bb3fe694dbfd29f2350eb2570df. This looks plausible: it is picking up where it left off before the basis pass fell over its horizon. CC: Roger Pau Monné CC: Jürgen Groß Signed-off-by: Ian Jackson --- adhoc-revtuple-generator | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adhoc-revtuple-generator b/adhoc-revtuple-generator index ac0f2463..c8d6f4ad 100755 --- a/adhoc-revtuple-generator +++ b/adhoc-revtuple-generator @@ -28,7 +28,7 @@ use Osstest; use Osstest::TestSupport; use Osstest::Executive; -our $num= 1000; +our $num= 5000; our $doupdate= 1; our $showrev= 0; @@ -553,7 +553,7 @@ sub main () { my @trees_continuous; foreach my $tree (@trees) { my $gen= tree_get_gen($tree); - my $count= 5000; + my $count= $num; my $found= 0; my $top= undef; while ($count-- > 0) {