| Message ID | 20191121101904.10295-1-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [for-4.13,v2] x86/vlapic: allow setting APIC_SPIV_FOCUS_DISABLED in x2APIC mode | expand |
On 21.11.2019 11:19, Roger Pau Monne wrote: > Current code unconditionally prevents setting APIC_SPIV_FOCUS_DISABLED > regardless of the processor model, which is not correct according to > the specification. > > This issue was discovered while trying to boot a pvshim with x2APIC > enabled. > > Always allow setting APIC_SPIV_FOCUS_DISABLED: the local APIC > provided to guests is emulated by Xen, and as such doesn't depend on > the features found on the hardware processor. Note for example that > Xen offers x2APIC support to guests even when the underlying hardware > doesn't have such feature. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
On 21.11.19 11:19, Roger Pau Monne wrote: > Current code unconditionally prevents setting APIC_SPIV_FOCUS_DISABLED > regardless of the processor model, which is not correct according to > the specification. > > This issue was discovered while trying to boot a pvshim with x2APIC > enabled. > > Always allow setting APIC_SPIV_FOCUS_DISABLED: the local APIC > provided to guests is emulated by Xen, and as such doesn't depend on > the features found on the hardware processor. Note for example that > Xen offers x2APIC support to guests even when the underlying hardware > doesn't have such feature. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Release-acked-by: Juergen Gross <jgross@suse.com> Juergen
diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index 9466258d6f..b790ba6bbd 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -993,6 +993,7 @@ int guest_wrmsr_x2apic(struct vcpu *v, uint32_t msr, uint64_t msr_content) case APIC_SPIV: if ( msr_content & ~(APIC_VECTOR_MASK | APIC_SPIV_APIC_ENABLED | + APIC_SPIV_FOCUS_DISABLED | (VLAPIC_VERSION & APIC_LVR_DIRECTED_EOI ? APIC_SPIV_DIRECTED_EOI : 0)) ) return X86EMUL_EXCEPTION;
Current code unconditionally prevents setting APIC_SPIV_FOCUS_DISABLED regardless of the processor model, which is not correct according to the specification. This issue was discovered while trying to boot a pvshim with x2APIC enabled. Always allow setting APIC_SPIV_FOCUS_DISABLED: the local APIC provided to guests is emulated by Xen, and as such doesn't depend on the features found on the hardware processor. Note for example that Xen offers x2APIC support to guests even when the underlying hardware doesn't have such feature. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Juergen Gross <jgross@suse.com> --- Changes since v1: - Always allow setting the APIC_SPIV_FOCUS_DISABLED bit. --- xen/arch/x86/hvm/vlapic.c | 1 + 1 file changed, 1 insertion(+)