diff mbox series

[3/8] x86: rename guest/hypercall.h to guest/xen-hypercall.h

Message ID 20191229183341.14877-4-liuwe@microsoft.com (mailing list archive)
State Superseded
Headers show
Series More Hyper-V infrastructure | expand

Commit Message

Wei Liu Dec. 29, 2019, 6:33 p.m. UTC
We will provide a header file for Hyper-V hypercalls.

No functional change.

Signed-off-by: Wei Liu <liuwe@microsoft.com>
---
 xen/include/asm-x86/guest.h                                | 2 +-
 xen/include/asm-x86/guest/{hypercall.h => xen-hypercall.h} | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename xen/include/asm-x86/guest/{hypercall.h => xen-hypercall.h} (99%)

Comments

Paul Durrant Jan. 3, 2020, 11:02 a.m. UTC | #1
On Sun, 29 Dec 2019 at 18:34, Wei Liu <wl@xen.org> wrote:
>
> We will provide a header file for Hyper-V hypercalls.
>
> No functional change.
>
> Signed-off-by: Wei Liu <liuwe@microsoft.com>

Reviewed-by: Paul Durrant <paul@xen.org>

> ---
>  xen/include/asm-x86/guest.h                                | 2 +-
>  xen/include/asm-x86/guest/{hypercall.h => xen-hypercall.h} | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  rename xen/include/asm-x86/guest/{hypercall.h => xen-hypercall.h} (99%)
>
> diff --git a/xen/include/asm-x86/guest.h b/xen/include/asm-x86/guest.h
> index 94448606d4..7f09c643d4 100644
> --- a/xen/include/asm-x86/guest.h
> +++ b/xen/include/asm-x86/guest.h
> @@ -19,11 +19,11 @@
>  #ifndef __X86_GUEST_H__
>  #define __X86_GUEST_H__
>
> -#include <asm/guest/hypercall.h>
>  #include <asm/guest/hyperv.h>
>  #include <asm/guest/hypervisor.h>
>  #include <asm/guest/pvh-boot.h>
>  #include <asm/guest/xen.h>
> +#include <asm/guest/xen-hypercall.h>
>  #include <asm/pv/shim.h>
>
>  #endif /* __X86_GUEST_H__ */
> diff --git a/xen/include/asm-x86/guest/hypercall.h b/xen/include/asm-x86/guest/xen-hypercall.h
> similarity index 99%
> rename from xen/include/asm-x86/guest/hypercall.h
> rename to xen/include/asm-x86/guest/xen-hypercall.h
> index d0d2f5022d..681d3aecd7 100644
> --- a/xen/include/asm-x86/guest/hypercall.h
> +++ b/xen/include/asm-x86/guest/xen-hypercall.h
> @@ -1,5 +1,5 @@
>  /******************************************************************************
> - * asm-x86/guest/hypercall.h
> + * asm-x86/guest/xen-hypercall.h
>   *
>   * This program is free software; you can redistribute it and/or
>   * modify it under the terms and conditions of the GNU General Public
> --
> 2.20.1
>
Jan Beulich Jan. 3, 2020, 4:16 p.m. UTC | #2
On 29.12.2019 19:33, Wei Liu wrote:
> We will provide a header file for Hyper-V hypercalls.
> 
> No functional change.
> 
> Signed-off-by: Wei Liu <liuwe@microsoft.com>

In principle
Acked-by: Jan Beulich <jbeulich@suse.com>
albeit ...

> ---
>  xen/include/asm-x86/guest.h                                | 2 +-
>  xen/include/asm-x86/guest/{hypercall.h => xen-hypercall.h} | 2 +-

... could we settle on guest/*-hcall.h to save on file name
length without (hopefully) becoming ambiguous?

Jan
Wei Liu Jan. 3, 2020, 4:18 p.m. UTC | #3
On Fri, Jan 03, 2020 at 05:16:53PM +0100, Jan Beulich wrote:
> On 29.12.2019 19:33, Wei Liu wrote:
> > We will provide a header file for Hyper-V hypercalls.
> > 
> > No functional change.
> > 
> > Signed-off-by: Wei Liu <liuwe@microsoft.com>
> 
> In principle
> Acked-by: Jan Beulich <jbeulich@suse.com>
> albeit ...
> 
> > ---
> >  xen/include/asm-x86/guest.h                                | 2 +-
> >  xen/include/asm-x86/guest/{hypercall.h => xen-hypercall.h} | 2 +-
> 
> ... could we settle on guest/*-hcall.h to save on file name
> length without (hopefully) becoming ambiguous?

That works for me.

Wei.

> 
> Jan
diff mbox series

Patch

diff --git a/xen/include/asm-x86/guest.h b/xen/include/asm-x86/guest.h
index 94448606d4..7f09c643d4 100644
--- a/xen/include/asm-x86/guest.h
+++ b/xen/include/asm-x86/guest.h
@@ -19,11 +19,11 @@ 
 #ifndef __X86_GUEST_H__
 #define __X86_GUEST_H__
 
-#include <asm/guest/hypercall.h>
 #include <asm/guest/hyperv.h>
 #include <asm/guest/hypervisor.h>
 #include <asm/guest/pvh-boot.h>
 #include <asm/guest/xen.h>
+#include <asm/guest/xen-hypercall.h>
 #include <asm/pv/shim.h>
 
 #endif /* __X86_GUEST_H__ */
diff --git a/xen/include/asm-x86/guest/hypercall.h b/xen/include/asm-x86/guest/xen-hypercall.h
similarity index 99%
rename from xen/include/asm-x86/guest/hypercall.h
rename to xen/include/asm-x86/guest/xen-hypercall.h
index d0d2f5022d..681d3aecd7 100644
--- a/xen/include/asm-x86/guest/hypercall.h
+++ b/xen/include/asm-x86/guest/xen-hypercall.h
@@ -1,5 +1,5 @@ 
 /******************************************************************************
- * asm-x86/guest/hypercall.h
+ * asm-x86/guest/xen-hypercall.h
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms and conditions of the GNU General Public