From patchwork Wed Jan 15 17:00:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 11335385 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E6AA513BD for ; Wed, 15 Jan 2020 17:01:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C272224656 for ; Wed, 15 Jan 2020 17:01:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="HJ7r3mEX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C272224656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irm25-0008Kl-In; Wed, 15 Jan 2020 17:00:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irm24-0008KH-7F for xen-devel@lists.xenproject.org; Wed, 15 Jan 2020 17:00:40 +0000 X-Inumbo-ID: 8612a5d6-37b8-11ea-85c2-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8612a5d6-37b8-11ea-85c2-12813bfff9fa; Wed, 15 Jan 2020 17:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1579107625; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U3Lce/KlFvj8bHLwbHXOYVYCrQrf7lO6uk+hxrmtXfU=; b=HJ7r3mEXeaMnPr6LkCWa3WJ/reGOX09vEOvCnadC/d83zsYuHQVopPH+ YYKSBOQUWKg/ybUOQaAsJFcT96OrjA8p79/mgmsao88IQSBSu+I6BILI3 7lnpizS3PxvuGpgR6oa8qiSrk101dv68VCBO6MbZ56Iu/Wcy3v9TZaZ3y 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: lZVw9eeQKx+dpPnMQOfmYWpRS7e/t0Uqe6ECB1wPO1/Ua8F5Zbu8F06VFBSGPifX1/r6aMAgLs gba2TxB1G8N/8l/x2QNeC7blYSujkGNTk03xxsKK9oFEF2EIVc78i8+N3eSPEH3kLDKi0KP0qn 4FJrFKdvtZ78cIKw/41oiSBQGWAK+L6FCVAIkLR6/YbtcU0Z8xP8oHk/C2bwp6v4IpZAdmV+Jf Ko8bLR7cSFitFG6npXv/XLzeHHi6FJV/tJP3/zbhfS7byBFGSQeU/ROViXv2d8k5qR6tgT36dc Llk= X-SBRS: 2.7 X-MesageID: 10973260 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,323,1574139600"; d="scan'208";a="10973260" From: Anthony PERARD To: Date: Wed, 15 Jan 2020 17:00:14 +0000 Message-ID: <20200115170015.249667-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200115170015.249667-1-anthony.perard@citrix.com> References: <20200115170015.249667-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [XEN PATCH v3 5/6] xen: Use $(CONFIG_CC_IS_CLANG) instead of $(clang) in Makefile X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Jan Beulich , Anthony PERARD , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Kconfig can check if $(CC) is clang or not, if it is CONFIG_CC_IS_CLANG will be set. With that patch, the hypervisor can be built using clang by running `make CC=clang CXX=clang++` without needed to provide an extra clang parameter. `make clang=y` still works as Config.mk will set CC and CXX. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper --- xen/Rules.mk | 8 ++++---- xen/arch/x86/Rules.mk | 2 +- xen/common/coverage/Makefile | 2 +- xen/include/Makefile | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index d053dbd26526..fcdafd029342 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -64,7 +64,7 @@ CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h CFLAGS-$(CONFIG_DEBUG_INFO) += -g CFLAGS += '-D__OBJECT_FILE__="$@"' -ifneq ($(clang),y) +ifneq ($(CONFIG_CC_IS_CLANG),y) # Clang doesn't understand this command line argument, and doesn't appear to # have an suitable alternative. The resulting compiled binary does function, # but has an excessively large symbol table. @@ -126,7 +126,7 @@ subdir-all := $(subdir-y) $(subdir-n) $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS += -DINIT_SECTIONS_ONLY ifeq ($(CONFIG_COVERAGE),y) -ifeq ($(clang),y) +ifeq ($(CONFIG_CC_IS_CLANG),y) COV_FLAGS := -fprofile-instr-generate -fcoverage-mapping else COV_FLAGS := -fprofile-arcs -ftest-coverage @@ -143,7 +143,7 @@ endif ifeq ($(CONFIG_LTO),y) CFLAGS += -flto -LDFLAGS-$(clang) += -plugin LLVMgold.so +LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so # Would like to handle all object files as bitcode, but objects made from # pure asm are in a different format and have to be collected separately. # Mirror the directory tree, collecting them as built_in_bin.o. @@ -197,7 +197,7 @@ SRCPATH := $(patsubst $(BASEDIR)/%,%,$(CURDIR)) %.o: %.c Makefile ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y) $(CC) $(CFLAGS) -c $< -o $(@D)/.$(@F).tmp -ifeq ($(clang),y) +ifeq ($(CONFIG_CC_IS_CLANG),y) $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< $(@D)/.$(@F).tmp $@ else $(OBJCOPY) --redefine-sym $(