From patchwork Wed Feb 26 11:33:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 11406265 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 997B41580 for ; Wed, 26 Feb 2020 11:35:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 761A220637 for ; Wed, 26 Feb 2020 11:35:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="Yqy6PcVw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 761A220637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6uxQ-0001IZ-FA; Wed, 26 Feb 2020 11:34:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6uxO-0001HY-W1 for xen-devel@lists.xenproject.org; Wed, 26 Feb 2020 11:34:27 +0000 X-Inumbo-ID: e39d476d-588b-11ea-93fd-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e39d476d-588b-11ea-93fd-12813bfff9fa; Wed, 26 Feb 2020 11:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1582716844; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zE3Bm6eVYCfqIOYWXu0WJVEEm1KRkMR9dJalinzfSvA=; b=Yqy6PcVw5sqfbzoqSNrnf5ZRN/5+DH/Ooo/ikrsNCiAcZl32NCVkg18/ hbl/Nb3Le5363ksZFo8YsMMnIyC/cGIYHG3f2tD632BZmmkXyKn2hIFe6 nTDe3Ho/COHfhcnpdWf/Kbk/9u1tWj6nVn4uLATsQzQuyWhdGJkUzJ6+p s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Bw5HqC+mPz7j6aCFOOTpGEeq/fRfk/GkAU2KhahDCOXn+5iFvaICeqjH0JvRffjwx5rWxY1UJ4 tWoEw/pluDFW7jjQnrLxCpjnrgGCp7hAiX9lBLmcPQFdCJ0jPlwC0jHO3/GyxFHGwDva42CZhf 6jLouLG3fFanY1LDdCdemvdtWSlsZ4ncMTW11rlFlsw1MhTBoRYjHWwEeBRsDNmchIyBp8Wxs5 jiB9nCt/+OfSC0AStHXQgC6H2NwXOZ/fuv6ZXtEjBPS5YnyBVapvAxHQ4KGIxviByDdHqgnXYg Rfg= X-SBRS: 2.7 X-MesageID: 13211004 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,487,1574139600"; d="scan'208";a="13211004" From: Anthony PERARD To: Date: Wed, 26 Feb 2020 11:33:35 +0000 Message-ID: <20200226113355.2532224-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200226113355.2532224-1-anthony.perard@citrix.com> References: <20200226113355.2532224-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [XEN PATCH v3 03/23] xen/build: Remove confusing comment on the %.s:%.S rule X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Jan Beulich , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" That comment was introduce by 3943db776371 ("[XEN] Can be built -std=gnu99 (except for .S files).") to explain why CFLAGS was removed from the command line. The comment is already written where the -std=gnu flags gets remove from AFLAGS, no need to repeat it. Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- Notes: v3: - new patch xen/Rules.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index d22a16d28282..c21203351a9f 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -230,7 +230,6 @@ $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o Makefile %.s: %.c Makefile $(CC) $(filter-out -Wa$(comma)%,$(CFLAGS)) -S $< -o $@ -# -std=gnu{89,99} gets confused by # as an end-of-line comment marker %.s: %.S Makefile $(CPP) $(filter-out -Wa$(comma)%,$(AFLAGS)) $< -o $@