| Message ID | 20200226113355.2532224-6-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen: Build system improvements | expand |
On Wed, Feb 26, 2020 at 11:33:37AM +0000, Anthony PERARD wrote: > The clang test for "asm()-s support .include." needs to be modified > because the symbolic link asm -> asm-x86 may not exist when the test > is runned. Since it's an x86 test, we don't need the link. > > This will be an issue with the following patch "xen/build: have the > root Makefile generates the CFLAGS". > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> So this is just a preparatory change in order to be able to run the checks before the headers are linked, but the current usage is perfectly fine AFAICT? (might be worth to try to clarify the commit message a bit in this regard). Thanks, Roger.
On 27.02.2020 10:05, Roger Pau Monné wrote: > On Wed, Feb 26, 2020 at 11:33:37AM +0000, Anthony PERARD wrote: >> The clang test for "asm()-s support .include." needs to be modified >> because the symbolic link asm -> asm-x86 may not exist when the test >> is runned. Since it's an x86 test, we don't need the link. >> >> This will be an issue with the following patch "xen/build: have the >> root Makefile generates the CFLAGS". >> >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com> > So this is just a preparatory change in order to be able to run the > checks before the headers are linked, but the current usage is > perfectly fine AFAICT? (might be worth to try to clarify the commit > message a bit in this regard). To be honest to me the description looks clear enough in this regard. But of course if improvements get suggested before this actually gets committed ... Jan
diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk index e69b8e697cc0..4b7ab784670c 100644 --- a/xen/arch/x86/Rules.mk +++ b/xen/arch/x86/Rules.mk @@ -26,7 +26,7 @@ $(call as-option-add,CFLAGS,CC,".L0: .L1: .skip (.L1 - .L0)",,\ -no-integrated-as) # Check whether clang asm()-s support .include. -$(call as-option-add,CFLAGS,CC,".include \"asm/indirect_thunk_asm.h\"",,\ +$(call as-option-add,CFLAGS,CC,".include \"asm-x86/indirect_thunk_asm.h\"",,\ -no-integrated-as) # Check whether clang keeps .macro-s between asm()-s:
The clang test for "asm()-s support .include." needs to be modified because the symbolic link asm -> asm-x86 may not exist when the test is runned. Since it's an x86 test, we don't need the link. This will be an issue with the following patch "xen/build: have the root Makefile generates the CFLAGS". Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Notes: v3: - new patch (needed for "xen/build: have the root Makefile generates the CFLAGS") xen/arch/x86/Rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)