From patchwork Thu Feb 27 18:14:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11409271 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1AAE1580 for ; Thu, 27 Feb 2020 18:16:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F1CD246B2 for ; Thu, 27 Feb 2020 18:16:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="iuZKAXQh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F1CD246B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j7NhC-0003cb-2S; Thu, 27 Feb 2020 18:15:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j7NhA-0003cW-Ks for xen-devel@lists.xenproject.org; Thu, 27 Feb 2020 18:15:36 +0000 X-Inumbo-ID: 26078246-598d-11ea-b7e8-bc764e2007e4 Received: from mail-wm1-x341.google.com (unknown [2a00:1450:4864:20::341]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 26078246-598d-11ea-b7e8-bc764e2007e4; Thu, 27 Feb 2020 18:15:35 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id a141so433471wme.2 for ; Thu, 27 Feb 2020 10:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jyV7bNjLu1SQ7vKcBd294xD9HrCo7tzU5S6Usg9xWsM=; b=iuZKAXQhruuVsFLUktBVg7py+mMqJxsH6IWepRR2Qdsx+kSrzXeemepz+H1XbKBw71 m7tZxW+SYKH+XWKDS6BzHZuIfcD3nYPcadw6X+2eqfcGwk0WFWIMA5DuBuxHBtYEq88J pIg952ThHq0ILPYGTY9qbGh/U9uPXXw7tRTaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jyV7bNjLu1SQ7vKcBd294xD9HrCo7tzU5S6Usg9xWsM=; b=IsNuMiOuyaT7BcuKYIn4JmvrmQgnY3mOcReLkUyQx1hpoAVJot9gOTj9ZtWr7DpyoD FW1yggfF5Q5PJfFxCDTTosqLgtLWkYVdRe9bqKNn9Cz2KZS3RNqgmydatnK7/azoMOSC ArXY4UxEXcaJZNPINqGZVTZbdGSo0+g/ZjZ3bgcs2q5i9rUQWLtwdLn9MtrmYlOdXB5P WqvIAxBHQqBhhB3Esv+ue3wBGU5JtdfFZt2SnqR/UxOkuii7uRHUZke9PUgeT8K9m1xR b4iXeqk+duRtllI6lyfjrwhXrEOI6EcwyDFsUK7RuIUq+fibmyhoKIjR654o+ndbpggw zn8w== X-Gm-Message-State: APjAAAUdUM4OGGPCQ69rIGQIjE/hWAJzUByEMqJia8D95JqdHdDguQFQ 4nNRY8E+nKTtos6IfswI3xtMSw== X-Google-Smtp-Source: APXvYqy1KGIqvDWaP9y/317NhLPsMTyJxxslCUMo+xlRnY58XN0X93cIaXfyPqnzF+0nskv3/XteqA== X-Received: by 2002:a1c:25c6:: with SMTP id l189mr49006wml.104.1582827333846; Thu, 27 Feb 2020 10:15:33 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id q1sm8551152wrw.5.2020.02.27.10.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 10:15:33 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Thu, 27 Feb 2020 19:14:35 +0100 Message-Id: <20200227181522.2711142-5-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200227181522.2711142-1-daniel.vetter@ffwll.ch> References: <20200227181522.2711142-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 04/51] drm: Set final_kfree in drm_dev_alloc X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Intel Graphics Development , Maarten Lankhorst , m.felsch@pengutronix.de, Maxime Ripard , Gerd Hoffmann , Thomas Zimmermann , Daniel Vetter , xen-devel@lists.xenproject.org, l.stach@pengutronix.de Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" I also did a full review of all callers, and only the xen driver forgot to call drm_dev_put in the failure path. Fix that up too. v2: I noticed that xen has a drm_driver.release hook, and uses drm_dev_alloc(). We need to remove the kfree from xen_drm_drv_release(). bochs also has a release hook, but leaked the drm_device ever since commit 0a6659bdc5e8221da99eebb176fd9591435e38de Author: Gerd Hoffmann Date: Tue Dec 17 18:04:46 2013 +0100 drm/bochs: new driver This patch here fixes that leak. Same for virtio, started leaking with commit b1df3a2b24a917f8853d43fe9683c0e360d2c33a Author: Gerd Hoffmann Date: Tue Feb 11 14:58:04 2020 +0100 drm/virtio: add drm_driver.release callback. Cc: Gerd Hoffmann Cc: Oleksandr Andrushchenko Cc: xen-devel@lists.xenproject.org Reviewed-by: Oleksandr Andrushchenko Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Oleksandr Andrushchenko Cc: xen-devel@lists.xenproject.org --- drivers/gpu/drm/drm_drv.c | 3 +++ drivers/gpu/drm/xen/xen_drm_front.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 3e5627d6eba6..9e62e28bbc62 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include @@ -819,6 +820,8 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver, return ERR_PTR(ret); } + drmm_add_final_kfree(dev, dev); + return dev; } EXPORT_SYMBOL(drm_dev_alloc); diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c index 4be49c1aef51..d22b5da38935 100644 --- a/drivers/gpu/drm/xen/xen_drm_front.c +++ b/drivers/gpu/drm/xen/xen_drm_front.c @@ -461,7 +461,6 @@ static void xen_drm_drv_release(struct drm_device *dev) drm_mode_config_cleanup(dev); drm_dev_fini(dev); - kfree(dev); if (front_info->cfg.be_alloc) xenbus_switch_state(front_info->xb_dev, @@ -561,6 +560,7 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info) fail_modeset: drm_kms_helper_poll_fini(drm_dev); drm_mode_config_cleanup(drm_dev); + drm_dev_put(drm_dev); fail: kfree(drm_info); return ret;