| Message ID | 20200305124504.3564-5-pdurrant@amzn.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | remove one more shared xenheap page: shared_info | expand |
On 05.03.2020 13:45, pdurrant@amzn.com wrote: > From: Paul Durrant <pdurrant@amazon.com> > > ... now that it is safe to assign them. > > This avoids relying on libxl (or whatever toolstack is in use) setting > max_pages up with sufficient 'slop' to allow all necessary ioreq server > pages to be allocated. > > Signed-off-by: Paul Durrant <pdurrant@amazon.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> While this one looks to be independent of earlier patches in this series (and hence could be considered a candidate for committing early), I don't think we want this committed ahead of (to be extended) patch 3, to avoid having more pages which may get mis- handled in a few places. It would be nice if in v4 you could add a respective post-commit-message remark. Jan
diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index f8a5c81546..648ef9137f 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -375,7 +375,7 @@ static int hvm_alloc_ioreq_mfn(struct hvm_ioreq_server *s, bool buf) return 0; } - page = alloc_domheap_page(s->target, 0); + page = alloc_domheap_page(s->target, MEMF_no_refcount); if ( !page ) return -ENOMEM;