diff mbox series

[1/3] xen/x86: ioapic: Use true/false in bad_ioapic_register()

Message ID 20200327190546.21580-2-julien@xen.org (mailing list archive)
State New, archived
Headers show
Series xen/x86: Simplify ioapic_init() | expand

Commit Message

Julien Grall March 27, 2020, 7:05 p.m. UTC 
From: Julien Grall <jgrall@amazon.com>

bad_ioapic_register() is return a bool, so we should switch to
true/false.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/x86/io_apic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wei Liu March 28, 2020, 11:01 a.m. UTC | #1 
On Fri, Mar 27, 2020 at 07:05:44PM +0000, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> bad_ioapic_register() is return a bool, so we should switch to
> true/false.

is return -> returns / is returning

> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Wei Liu <wl@xen.org>
Jan Beulich March 31, 2020, 11:05 a.m. UTC | #2 
On 28.03.2020 12:01, Wei Liu wrote:
> On Fri, Mar 27, 2020 at 07:05:44PM +0000, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> bad_ioapic_register() is return a bool, so we should switch to
>> true/false.
> 
> is return -> returns / is returning
> 
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> Reviewed-by: Wei Liu <wl@xen.org>

Acked-by: Jan Beulich <jbeulich@suse.com>
diff mbox series

Patch

diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index e98e08e9c8..9868933287 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -2531,10 +2531,10 @@  static __init bool bad_ioapic_register(unsigned int idx)
     {
         printk(KERN_WARNING "I/O APIC %#x registers return all ones, skipping!\n",
                mp_ioapics[idx].mpc_apicaddr);
-        return 1;
+        return true;
     }
 
-    return 0;
+    return false;
 }
 
 void __init init_ioapic_mappings(void)