From patchwork Wed Apr 15 11:09:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 11491107 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42E3D81 for ; Wed, 15 Apr 2020 11:11:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F24120732 for ; Wed, 15 Apr 2020 11:11:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="VfI87gXG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F24120732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOfvy-0007Bh-89; Wed, 15 Apr 2020 11:10:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOfvx-0007Bc-N1 for xen-devel@lists.xenproject.org; Wed, 15 Apr 2020 11:10:21 +0000 X-Inumbo-ID: b1d31636-7f09-11ea-b58d-bc764e2007e4 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b1d31636-7f09-11ea-b58d-bc764e2007e4; Wed, 15 Apr 2020 11:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1586949020; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bVsRmRMDDBof1U/c70ZBUtPRTiWlxPgX4Wung/sAkwo=; b=VfI87gXGVGmJRUDBisGG/oDsUIWgO+dhy5eN3tTCZPttWpWB3w3ZbSoP HkIUFN5PP84k+Pg//zfxhQIqNN4OD0G+2rWqTLDoItOz/2Wy4vHaKp96x jQo5neFlMLjlr1oASdCggWoFcnCnrYpd3SJMQIOpwxDmbkiY/gtP/QM58 o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: vQ1Zjyzalv6YIzO8e7qZHbLJW1pUFs3APvaY+9nCMhylLOvSkbnx4IEqIZ4FJaUm36k60mUQFN TB8ctmU4KxaXp97/gUnXmhUBLQEfysgFxs5XOyqKI+BRTPcJfs9yyklwxJUKr7L6Fz5SphpWH0 RS4ZnRQD0MtJR2bVQQQb6nTZ58SqJ/6DUbl7n+s2x3O8GS51hS+5AMGGp/XDswxPpeF5NPRNZj 7p8ljeQy1u8s21gMyrk+uPMvEV+EMu8ZLIJBeDpEQWrOfEwX2FwZn/nwdxwGefQjXuUnvJt3sN fQ4= X-SBRS: 2.7 X-MesageID: 16379266 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,386,1580792400"; d="scan'208";a="16379266" From: Roger Pau Monne To: Subject: [PATCH] x86/altp2m: add missing break Date: Wed, 15 Apr 2020 13:09:39 +0200 Message-ID: <20200415110939.9481-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Add a missing break in the HVMOP_altp2m_set_visibility case, or else code flow will continue into the default case and trigger the assert. Fixes: 3fd3e9303ec4b1 ('x86/altp2m: hypercall to set altp2m view visibility') Coverity-ID: 1461759 Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu --- xen/arch/x86/hvm/hvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 6f6f3f73a8..45959d3412 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4798,6 +4798,7 @@ static int do_altp2m_op( else rc = p2m_set_altp2m_view_visibility(d, idx, a.u.set_visibility.visible); + break; } default: