From patchwork Mon Jun 8 16:00:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11593503 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A90990 for ; Mon, 8 Jun 2020 16:03:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 659A2206C3 for ; Mon, 8 Jun 2020 16:03:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ws7dibcH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 659A2206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiKEY-0004lQ-AS; Mon, 08 Jun 2020 16:02:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiKEW-0004k4-Uc for xen-devel@lists.xenproject.org; Mon, 08 Jun 2020 16:02:44 +0000 X-Inumbo-ID: 7d4f0fb0-a9a1-11ea-b292-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [205.139.110.61]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 7d4f0fb0-a9a1-11ea-b292-12813bfff9fa; Mon, 08 Jun 2020 16:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Lcxf8cj+CxLJSf8aQEjLTWyUhOWt7SwLOi9PO4gCM4=; b=Ws7dibcH76dLE0IMqS9G+8PrYyLzxFdL2Mzcp1ynzfIPrCCD17/vI0ZiXSlye+Fu7X5+s/ vHIAfOR4oZQttPgKRoU5jrIaHrUT5x2AsTSubzvkPxcWvv57+AeOE7/wcx3Aql78BIuH0a G9Rkc28mHLaJIqQ/9FqHVs4eFodQM0o= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-138-yQDt05YoPFm1mWxhzHE84Q-1; Mon, 08 Jun 2020 12:02:42 -0400 X-MC-Unique: yQDt05YoPFm1mWxhzHE84Q-1 Received: by mail-wr1-f70.google.com with SMTP id w4so7365688wrl.13 for ; Mon, 08 Jun 2020 09:02:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7Lcxf8cj+CxLJSf8aQEjLTWyUhOWt7SwLOi9PO4gCM4=; b=ZlwjrFd6WBtEioLlIXCiMa8E8t4grs9ACbMWwj1xUqPQckvMsdB3A1FPoEGmT+qkE3 Y0HQi8L+d1XvvpBVXXbnaOtSAL9k+R3G9Vq0ZandharXTk7V9EstjybEQDt5+3ToBUK3 xd+sVQZPG1iQtQ4AX7q0uPW7QmXF7ciSlbrJzIrKB8cUHrVkoiCHOGgmxgVzhzQstmPJ CAiRNIiurrQ24WBFHgQvWGY8kdsavlw8zw7wylmUnpLGw6rYBLIK48Op1GU9P3zX31yz tLtWfrKs/3ZmaWKFmzdxy3FjN2QgjPSGKMlFX4zGBMJb/rBtRWi68mQxBYVJ+FYav2nI /TqQ== X-Gm-Message-State: AOAM530CyrDZGJI/U59Yjmu2qg1Zcz9G9/0tFL+J/uIHwsERuTeeFFUg LDNNbGoHGLd0TfDqrTPpDWnUv0PKyNZyBXHqCvHpsQAl35Efcqk/rS1wnKRCCngi5ENTfx+DiqM pzJiEo0jj6WjYiChPvTqx+KYglhY= X-Received: by 2002:a1c:6056:: with SMTP id u83mr60177wmb.138.1591632161698; Mon, 08 Jun 2020 09:02:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztIcOuKmMAnKpEQL/s7NO4XNCQYfWj4X6mQCPh85ejUPn/olQa6U5W1zctaCPlsras+JjNJA== X-Received: by 2002:a1c:6056:: with SMTP id u83mr60154wmb.138.1591632161497; Mon, 08 Jun 2020 09:02:41 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id a81sm19165wmd.25.2020.06.08.09.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:02:40 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:29 +0200 Message-Id: <20200608160044.15531-21-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Marcel Apfelbaum , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lurea?= =?utf-8?q?u?= , David Gibson , Andrzej Zaborowski , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/i8259.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 51b27f6a34..9d9609cdab 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -30,6 +30,7 @@ #include "qemu/log.h" #include "hw/isa/i8259_internal.h" #include "trace.h" +#include "hw/qdev-deprecated.h" /* debug PIC */ //#define DEBUG_PIC @@ -414,6 +415,8 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq) ISADevice *isadev; int i; + qdev_warn_deprecated_function_used(); + irq_set = g_new0(qemu_irq, ISA_NUM_IRQS); isadev = i8259_init_chip(TYPE_I8259, bus, true);