| Message ID | 20200608160044.15531-31-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/qdev: Warn when using pre-qdev/QOM devices | expand |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/ppc/virtex_ml507.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c > index 0dacfcd236..17b8036c38 100644 > --- a/hw/ppc/virtex_ml507.c > +++ b/hw/ppc/virtex_ml507.c > @@ -40,7 +40,7 @@ > #include "qemu/log.h" > #include "qemu/option.h" > #include "exec/address-spaces.h" > - > +#include "hw/qdev-deprecated.h" > #include "hw/ppc/ppc.h" > #include "hw/ppc/ppc4xx.h" > #include "hw/qdev-properties.h" > @@ -95,6 +95,8 @@ static PowerPCCPU *ppc440_init_xilinx(const char *cpu_type, uint32_t sysclk) > CPUPPCState *env; > qemu_irq *irqs; > > + qdev_warn_deprecated_function_used(); > + > cpu = POWERPC_CPU(cpu_create(cpu_type)); > env = &cpu->env; > > This one is okay. Paolo
diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c index 0dacfcd236..17b8036c38 100644 --- a/hw/ppc/virtex_ml507.c +++ b/hw/ppc/virtex_ml507.c @@ -40,7 +40,7 @@ #include "qemu/log.h" #include "qemu/option.h" #include "exec/address-spaces.h" - +#include "hw/qdev-deprecated.h" #include "hw/ppc/ppc.h" #include "hw/ppc/ppc4xx.h" #include "hw/qdev-properties.h" @@ -95,6 +95,8 @@ static PowerPCCPU *ppc440_init_xilinx(const char *cpu_type, uint32_t sysclk) CPUPPCState *env; qemu_irq *irqs; + qdev_warn_deprecated_function_used(); + cpu = POWERPC_CPU(cpu_create(cpu_type)); env = &cpu->env;
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/ppc/virtex_ml507.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)