| Message ID | 20200704144943.18292-9-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/usb: Give it love, reduce 'hw/usb.h' inclusion out of hw/usb/ | expand |
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > We only use these register definitions in files under the > hw/usb/ directory. Keep that header local by moving it there. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > {include/hw => hw}/usb/dwc2-regs.h | 0 > hw/usb/hcd-dwc2.c | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename {include/hw => hw}/usb/dwc2-regs.h (100%) > > diff --git a/include/hw/usb/dwc2-regs.h b/hw/usb/dwc2-regs.h > similarity index 100% > rename from include/hw/usb/dwc2-regs.h > rename to hw/usb/dwc2-regs.h > diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c > index ccf05d0823..252b60ef65 100644 > --- a/hw/usb/hcd-dwc2.c > +++ b/hw/usb/hcd-dwc2.c > @@ -34,7 +34,6 @@ > #include "qemu/osdep.h" > #include "qemu/units.h" > #include "qapi/error.h" > -#include "hw/usb/dwc2-regs.h" > #include "hw/usb/hcd-dwc2.h" > #include "hw/irq.h" > #include "sysemu/dma.h" > @@ -43,6 +42,7 @@ > #include "qemu/timer.h" > #include "qemu/log.h" > #include "hw/qdev-properties.h" > +#include "dwc2-regs.h" > > #define USB_HZ_FS 12000000 > #define USB_HZ_HS 96000000 > -- > 2.21.3 > >
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > We only use these register definitions in files under the > hw/usb/ directory. Keep that header local by moving it there. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > {include/hw => hw}/usb/dwc2-regs.h | 0 > hw/usb/hcd-dwc2.c | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename {include/hw => hw}/usb/dwc2-regs.h (100%) > > diff --git a/include/hw/usb/dwc2-regs.h b/hw/usb/dwc2-regs.h > similarity index 100% > rename from include/hw/usb/dwc2-regs.h > rename to hw/usb/dwc2-regs.h > diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c > index ccf05d0823..252b60ef65 100644 > --- a/hw/usb/hcd-dwc2.c > +++ b/hw/usb/hcd-dwc2.c > @@ -34,7 +34,6 @@ > #include "qemu/osdep.h" > #include "qemu/units.h" > #include "qapi/error.h" > -#include "hw/usb/dwc2-regs.h" > #include "hw/usb/hcd-dwc2.h" > #include "hw/irq.h" > #include "sysemu/dma.h" > @@ -43,6 +42,7 @@ > #include "qemu/timer.h" > #include "qemu/log.h" > #include "hw/qdev-properties.h" > +#include "dwc2-regs.h" > > #define USB_HZ_FS 12000000 > #define USB_HZ_HS 96000000 > -- > 2.21.3 > > Reviewed-by: Paul Zimmerman <pauldzim@gmail.com>
diff --git a/include/hw/usb/dwc2-regs.h b/hw/usb/dwc2-regs.h similarity index 100% rename from include/hw/usb/dwc2-regs.h rename to hw/usb/dwc2-regs.h diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c index ccf05d0823..252b60ef65 100644 --- a/hw/usb/hcd-dwc2.c +++ b/hw/usb/hcd-dwc2.c @@ -34,7 +34,6 @@ #include "qemu/osdep.h" #include "qemu/units.h" #include "qapi/error.h" -#include "hw/usb/dwc2-regs.h" #include "hw/usb/hcd-dwc2.h" #include "hw/irq.h" #include "sysemu/dma.h" @@ -43,6 +42,7 @@ #include "qemu/timer.h" #include "qemu/log.h" #include "hw/qdev-properties.h" +#include "dwc2-regs.h" #define USB_HZ_FS 12000000 #define USB_HZ_HS 96000000
We only use these register definitions in files under the hw/usb/ directory. Keep that header local by moving it there. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- {include/hw => hw}/usb/dwc2-regs.h | 0 hw/usb/hcd-dwc2.c | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename {include/hw => hw}/usb/dwc2-regs.h (100%)